[Settings] Use a "Window Prompt" instead of custom components

RESOLVED INVALID

Status

Firefox OS
Gaia::Settings
RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: Sergi, Assigned: ivanovpavel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: visual design, incorrect implementation)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 700357 [details]
Window Prompt :: Screenshot

We should have a standard prompt where we can ask the user to provide info or edit a string, like in the case of Settings>Bluetooth>Change Phone Name.

The current implementation uses a custom prompt and this should be solved by using a system component.

Comment 1

5 years ago
This is important not only for the instances in our apps, but also because it's a common JS interaction the web. The browser should be prepared to handled this through system componentes, just like value selectors.
Pavel, feel free to take it if you have some free cycles.
Assignee: nobody → pivanov
Hmm, looks like I talked too fast once again… :-/

(In reply to Sergi from comment #0)
> We should have a standard prompt where we can ask the user to provide info
> or edit a string, like in the case of Settings>Bluetooth>Change Phone Name.
> 
> The current implementation uses a custom prompt and this should be solved by
> using a system component.

Wrong: as Pavel just found out, this is our standard prompt component. Hence, closing as INVALID.

If any other text input is using a different dialog then it’s a bug — or at least, it’s not using a standard prompt.

I’m not sure I like our current implementation (especially because the OK/Cancel buttons get moved when the onscreen keyboard appears) but I’m pretty sure it matches the specs we had so far.

Please open another bug in order to revise the specs for this prompt dialog. There’s definitely room for improvement and I like your design — thought it could *not* be a standard prompt since we can only provide one title, see: https://developer.mozilla.org/en-US/docs/DOM/window.prompt
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.