Closed
Bug 828975
Opened 11 years ago
Closed 11 years ago
Cleanup nsHTMLCSSUtils::ElementsSameStyle a bit
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
8.42 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #700370 -
Flags: review?(ehsan)
Comment 1•11 years ago
|
||
Comment on attachment 700370 [details] [diff] [review] Patch v1 Review of attachment 700370 [details] [diff] [review]: ----------------------------------------------------------------- ::: editor/libeditor/html/nsHTMLCSSUtils.cpp @@ +1392,5 @@ > +nsHTMLCSSUtils::GetInlineStyles(dom::Element* aElement, > + nsIDOMCSSStyleDeclaration** aCssDecl, > + uint32_t* aLength) > +{ > + return GetInlineStyles(static_cast<nsISupports*>(aElement), aCssDecl, aLength); The cast should not be necessary here. @@ +1400,5 @@ > +nsHTMLCSSUtils::GetInlineStyles(nsIDOMElement* aElement, > + nsIDOMCSSStyleDeclaration** aCssDecl, > + uint32_t* aLength) > +{ > + return GetInlineStyles(static_cast<nsISupports*>(aElement), aCssDecl, aLength); nor here.
Attachment #700370 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Do explain how removing the cast will not lead to infinite recursion :)
Comment 3•11 years ago
|
||
(In reply to comment #2) > Do explain how removing the cast will not lead to infinite recursion :) Ah, I thought you're writing code in my imaginary programming language which does what I mean it to, but no, this is just C++. Nevermind then, I guess! ;-)
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5b3c75e859d9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•