Closed Bug 828975 Opened 11 years ago Closed 11 years ago

Cleanup nsHTMLCSSUtils::ElementsSameStyle a bit

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
      No description provided.
Attachment #700370 - Flags: review?(ehsan)
Comment on attachment 700370 [details] [diff] [review]
Patch v1

Review of attachment 700370 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLCSSUtils.cpp
@@ +1392,5 @@
> +nsHTMLCSSUtils::GetInlineStyles(dom::Element* aElement,
> +                                nsIDOMCSSStyleDeclaration** aCssDecl,
> +                                uint32_t* aLength)
> +{
> +  return GetInlineStyles(static_cast<nsISupports*>(aElement), aCssDecl, aLength);

The cast should not be necessary here.

@@ +1400,5 @@
> +nsHTMLCSSUtils::GetInlineStyles(nsIDOMElement* aElement,
> +                                nsIDOMCSSStyleDeclaration** aCssDecl,
> +                                uint32_t* aLength)
> +{
> +  return GetInlineStyles(static_cast<nsISupports*>(aElement), aCssDecl, aLength);

nor here.
Attachment #700370 - Flags: review?(ehsan) → review+
Do explain how removing the cast will not lead to infinite recursion :)
(In reply to comment #2)
> Do explain how removing the cast will not lead to infinite recursion :)

Ah, I thought you're writing code in my imaginary programming language which does what I mean it to, but no, this is just C++.  Nevermind then, I guess!  ;-)
https://hg.mozilla.org/mozilla-central/rev/5b3c75e859d9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: