[Settings] "Check Now" button in Device Information>Software Updates should be disabled when there're no connections available

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Sergi, Assigned: ivanovpavel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: visual design [UX-P2], TEF_REQ, visual-tracking)

Attachments

(2 attachments, 3 obsolete attachments)

Comment hidden (empty)
(Reporter)

Updated

5 years ago
Keywords: polish
Whiteboard: visual design → visual design [UX-P2]
(Reporter)

Comment 1

5 years ago
Created attachment 706373 [details]
Check for Updates :: Screenshot

Updated

5 years ago
Whiteboard: visual design [UX-P2] → visual design [UX-P2], TEF_REQ
(Reporter)

Comment 2

5 years ago
Created attachment 707533 [details]
Check for Updates :: Screenshot
Attachment #706373 - Attachment is obsolete: true
Assignee: nobody → pivanov
Created attachment 710891 [details]
patch for UX branch
Attachment #710891 - Flags: review?(kaze)

Comment 4

5 years ago
Pavel, your JS patch should be PRed in gaia/master directly
Ok I will make a PR to gaia/master directly. Thanks Sam :)
Attachment #710891 - Attachment is obsolete: true
Attachment #710891 - Flags: review?(kaze)
Created attachment 712851 [details]
patch for Gaia repo
Attachment #712851 - Flags: review?(sjochimek)

Updated

5 years ago
Attachment #712851 - Flags: review?(sjochimek) → review?(21)
Comment on attachment 712851 [details]
patch for Gaia repo

Let's do a new iteration on the patch.
Attachment #712851 - Flags: review?(21)
Hi Pavel, what's the status of this bug?
Flags: needinfo?(pivanov)
Whiteboard: visual design [UX-P2], TEF_REQ → visual design [UX-P2], TEF_REQ, visual-tracking
I think I need help from Sam
Flags: needinfo?(pivanov) → needinfo?(sjochimek)

Comment 10

4 years ago
Created attachment 767162 [details]
PR Github Gaia
Attachment #712851 - Attachment is obsolete: true
Attachment #767162 - Flags: review?
Flags: needinfo?(sjochimek)

Updated

4 years ago
Attachment #767162 - Flags: review? → review?(21)
Attachment #767162 - Flags: review?(21) → review?(etienne)
Comment on attachment 767162 [details]
PR Github Gaia

Comments on github!
Attachment #767162 - Flags: review?(etienne)

Comment 12

4 years ago
Comment on attachment 767162 [details]
PR Github Gaia

Etienne: Didn't know about the navigator.onLine API thanks !
I've updated the PR.
Attachment #767162 - Flags: review?(etienne)
Comment on attachment 767162 [details]
PR Github Gaia

tiny nit on github, but r=me!
Attachment #767162 - Flags: review?(etienne) → review+

Comment 14

4 years ago
thanks

landed in master: https://github.com/mozilla-b2g/gaia/commit/07712b06ed6612d0f6e6d8555ce3b9e407125888
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.