829101 - Update tests for <input type='{email,number}'> value sanitization tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch

Happier? :)

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 700528 [details] [diff] [review]
Patch

Review of attachment 700528 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks.

::: content/html/content/test/forms/test_input_sanitization.html
@@ +51,5 @@
>      case "tel":
>        return aValue.replace(/[\n\r]/g, "");
>      case "url":
>      case "email":
> +      return aValue.replace(/[\n\r]/g, "").replace(/^[\u0020\u0009\t\u000a\u000c\u000d]+|[\u0020\u0009\t\u000a\u000c\u000d]+$/g, "");

\t === \u0009, no?

@@ +56,3 @@
>      case "number":
> +      var number = Number(aValue);
> +      return number === number ? aValue : "";

!isNaN(Number(aValue)), maybe?

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to :Ms2ger from comment #2)
> ::: content/html/content/test/forms/test_input_sanitization.html
> @@ +51,5 @@
> >      case "tel":
> >        return aValue.replace(/[\n\r]/g, "");
> >      case "url":
> >      case "email":
> > +      return aValue.replace(/[\n\r]/g, "").replace(/^[\u0020\u0009\t\u000a\u000c\u000d]+|[\u0020\u0009\t\u000a\u000c\u000d]+$/g, "");
> 
> \t === \u0009, no?

Yes. And \u0020 is " ". Just want to keep the unicode values for all the characters.

> @@ +56,3 @@
> >      case "number":
> > +      var number = Number(aValue);
> > +      return number === number ? aValue : "";
> 
> !isNaN(Number(aValue)), maybe?

Maybe, indeed.

Comment 4

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8164852113cd

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8164852113cd