829128 - fakedevices support for SUT checks

Status: RESOLVED FIXED

(Testing Graveyard :: Mozpool, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Now that we have mozpool talking to SUT, we'll need support for that in the fake devices.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

On the staging server, I have all images configured with has_sut_agent=0 temporarily.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug829128.patch

This uncovered two bugs.

1. When using SUT to reboot, the state machine was not setting up the PXE config first.  This was easy to fix (the first hunk).

2. The PowerCycleMixin uses data.device_has_sut_agent to determine whether the device has a SUT agent.  However, this is based on device.last_image_id, which was reset in on_please_image().

I think the fix for #2 is to add a next_image_id column to the devices table, and use *that* to store the desired image while retrying the reboot, rather than sticking it in (nominally incorrect) last_image_id column.

Comment 3

[Mark Côté [:mcote]]

Comment on attachment 707267 [details] [diff] [review]
bug829128.patch

Review of attachment 707267 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  And yeah, I think it makes sense to have next_image_id.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

I'll land this after 2.0.2.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

landed.

Comment 6

[Mark Côté [:mcote]]

Should we file #2 from comment 2 as a separate bug then?

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

That's getting rolled into what's turning out to be a big overhaul that will already cover several bugs, so no, I don't think so.  Good catch though!