fakedevices support for SUT checks

RESOLVED FIXED

Status

Testing Graveyard
Mozpool
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: dustin, Assigned: dustin)

Tracking

Details

Attachments

(1 attachment)

Now that we have mozpool talking to SUT, we'll need support for that in the fake devices.
On the staging server, I have all images configured with has_sut_agent=0 temporarily.
Created attachment 707267 [details] [diff] [review]
bug829128.patch

This uncovered two bugs.

1. When using SUT to reboot, the state machine was not setting up the PXE config first.  This was easy to fix (the first hunk).

2. The PowerCycleMixin uses data.device_has_sut_agent to determine whether the device has a SUT agent.  However, this is based on device.last_image_id, which was reset in on_please_image().

I think the fix for #2 is to add a next_image_id column to the devices table, and use *that* to store the desired image while retrying the reboot, rather than sticking it in (nominally incorrect) last_image_id column.
Assignee: nobody → dustin
Attachment #707267 - Flags: review?(mcote)

Comment 3

5 years ago
Comment on attachment 707267 [details] [diff] [review]
bug829128.patch

Review of attachment 707267 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  And yeah, I think it makes sense to have next_image_id.
Attachment #707267 - Flags: review?(mcote) → review+
I'll land this after 2.0.2.
landed.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 6

5 years ago
Should we file #2 from comment 2 as a separate bug then?
That's getting rolled into what's turning out to be a big overhaul that will already cover several bugs, so no, I don't think so.  Good catch though!
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.