Closed Bug 829294 Opened 9 years ago Closed 9 years ago

Some rooting for DebugScopeProxy

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

Attachments

(1 file)

Attached patch v1Splinter Review
This fixes 10 more failures or so.
Attachment #700671 - Flags: review?(terrence)
Comment on attachment 700671 [details] [diff] [review]
v1

Review of attachment 700671 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: js/src/vm/ScopeObject.cpp
@@ +1225,5 @@
>          }
>  
>          /* Handle unaliased let and catch bindings at block scope. */
>          if (scope->isClonedBlock()) {
> +            Rooted<ClonedBlockObject *> block(cx, &scope->asClonedBlock());

Did a double-take on seeing this: didn't know it was a JSObject subclass.
Attachment #700671 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/7c92fc2dcd48
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.