Closed
Bug 829316
Opened 11 years ago
Closed 11 years ago
Chat icon vertical align
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 21.0
People
(Reporter: markac, Assigned: Paenglab)
Details
Attachments
(2 files, 1 obsolete file)
|
34.13 KB,
image/png
|
Details | |
|
1.09 KB,
patch
|
mconley
:
review+
mconley
:
ui-review+
|
Details | Diff | Splinter Review |
vai.png
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20100101 Firefox/17.0 Build ID: 20121128204232 Actual results: Wrong alignment.
|
Assignee | |
Comment 1•11 years ago
|
||
Good catch Mariusz and thanks for the report. This happens only in "Icons and Text" mode with Aero theme but it's good to apply on all modes except text only. Mike, I've chosen you for review because you have a always working Win7 machine to check this bug.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #701444 -
Flags: ui-review?(mconley)
Attachment #701444 -
Flags: review?(mconley)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 701444 [details] [diff] [review] patch Hey Paenglab, Code looks good! Just one visual nit - when I switch to Icons & Text, while I have the customize window open, the chat icon is still misaligned. http://i.imgur.com/D31K8eE.png Can we take care of that case too? -Mike
Attachment #701444 -
Flags: ui-review?(mconley)
Attachment #701444 -
Flags: ui-review-
Attachment #701444 -
Flags: review?(mconley)
Attachment #701444 -
Flags: review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Expanded the rule to work also in customize mode.
Attachment #701444 -
Attachment is obsolete: true
Attachment #710679 -
Flags: ui-review?(mconley)
Attachment #710679 -
Flags: review?(mconley)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 710679 [details] [diff] [review] patch v2 Review of attachment 710679 [details] [diff] [review]: ----------------------------------------------------------------- Yep, way better. Thanks Paenglab!
Attachment #710679 -
Flags: ui-review?(mconley)
Attachment #710679 -
Flags: ui-review+
Attachment #710679 -
Flags: review?(mconley)
Attachment #710679 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/1f1db96d6571
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0
You need to log in
before you can comment on or make changes to this bug.
Description
•