Last Comment Bug 829316 - Chat icon vertical align
: Chat icon vertical align
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Toolbars and Tabs (show other bugs)
: 17 Branch
: x86 Windows 7
: -- normal (vote)
: Thunderbird 21.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-10 14:41 PST by Mariusz Kacki
Modified: 2013-02-06 07:59 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
vai.png (34.13 KB, image/png)
2013-01-10 14:41 PST, Mariusz Kacki
no flags Details
patch (1.02 KB, patch)
2013-01-12 02:41 PST, Richard Marti (:Paenglab)
mconley: review+
mconley: ui‑review-
Details | Diff | Review
patch v2 (1.09 KB, patch)
2013-02-06 07:05 PST, Richard Marti (:Paenglab)
mconley: review+
mconley: ui‑review+
Details | Diff | Review

Description Mariusz Kacki 2013-01-10 14:41:14 PST
Created attachment 700696 [details]
vai.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121128204232



Actual results:

Wrong alignment.
Comment 1 Richard Marti (:Paenglab) 2013-01-12 02:41:43 PST
Created attachment 701444 [details] [diff] [review]
patch

Good catch Mariusz and thanks for the report.

This happens only in "Icons and Text" mode with Aero theme but it's good to apply on all modes except text only.

Mike, I've chosen you for review because you have a always working Win7 machine to check this bug.
Comment 2 Mike Conley (:mconley) - (needinfo me!) 2013-02-06 06:52:18 PST
Comment on attachment 701444 [details] [diff] [review]
patch

Hey Paenglab,

Code looks good! Just one visual nit - when I switch to Icons & Text, while I have the customize window open, the chat icon is still misaligned.

http://i.imgur.com/D31K8eE.png

Can we take care of that case too?

-Mike
Comment 3 Richard Marti (:Paenglab) 2013-02-06 07:05:14 PST
Created attachment 710679 [details] [diff] [review]
patch v2

Expanded the rule to work also in customize mode.
Comment 4 Mike Conley (:mconley) - (needinfo me!) 2013-02-06 07:11:18 PST
Comment on attachment 710679 [details] [diff] [review]
patch v2

Review of attachment 710679 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, way better. Thanks Paenglab!
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-02-06 07:59:28 PST
https://hg.mozilla.org/comm-central/rev/1f1db96d6571

Note You need to log in before you can comment on or make changes to this bug.