829352 - IonMonkey: Add IonMacroAssembler methods for generating addPtr, subPtr, xorPtr, and andPtr variants

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Kannan Vijayan [:djvj]]

Attachment: Add instruction generator methods for XOR, AND, ADD, and SUB variants.

This is needed for some baseline code, but general enough to make it suitable for trunk inclusion.

Specific MacroAssembler methods added:
xorPtr(Imm32, Register)
andPtr(Imm32, Register)
addPtr(Address, Register)
subPtr(Address, Register)

Comment 1

[Kannan Vijayan [:djvj]]

Thanks Tom, missed that.

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 700749 [details] [diff] [review]
Add instruction generator methods for  XOR, AND, ADD, and SUB variants.

Review of attachment 700749 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good.

Comment 3

[Kannan Vijayan [:djvj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48b58294a6d5

Comment 4

[Ed Morley [:emorley]]

Backed out for breaking the build:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=48b58294a6d5

https://hg.mozilla.org/integration/mozilla-inbound/rev/e523e9cd94dc

Comment 5

[Kannan Vijayan [:djvj]]

Build breakage fixed, checked, repushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1360be430b5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e1360be430b5

Comment 7

[Kannan Vijayan [:djvj]]

Minor additional patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/329fbaeaa0d4

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/329fbaeaa0d4