Closed Bug 829352 Opened 10 years ago Closed 10 years ago

IonMonkey: Add IonMacroAssembler methods for generating addPtr, subPtr, xorPtr, and andPtr variants

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: djvj, Unassigned)

References

Details

Attachments

(1 file)

This is needed for some baseline code, but general enough to make it suitable for trunk inclusion.

Specific MacroAssembler methods added:
xorPtr(Imm32, Register)
andPtr(Imm32, Register)
addPtr(Address, Register)
subPtr(Address, Register)
Attachment #700749 - Flags: review?(nicolas.b.pierron)
Attachment #700749 - Attachment is patch: true
Thanks Tom, missed that.
Comment on attachment 700749 [details] [diff] [review]
Add instruction generator methods for  XOR, AND, ADD, and SUB variants.

Review of attachment 700749 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good.
Attachment #700749 - Flags: review?(nicolas.b.pierron) → review+
Build breakage fixed, checked, repushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1360be430b5
https://hg.mozilla.org/mozilla-central/rev/e1360be430b5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Summary: IonMonkey: Add IonMacroAssembler methods for generating addPtr, subPtr, xorPtr, and addPtr variants → IonMonkey: Add IonMacroAssembler methods for generating addPtr, subPtr, xorPtr, and andPtr variants
You need to log in before you can comment on or make changes to this bug.