829420 - [Camera] In GonkNativeWindow::dequeueBuffer, -1 will be used as index to access an Arrary

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Marco Chen [:mchen]]

Please refer to link as below for exact code position.
http://mxr.mozilla.org/mozilla-central/source/dom/camera/GonkNativeWindow.cpp#228

And to use -1 as an index to access array may causes segfault.

Comment 1

[Marco Chen [:mchen]]

Attachment: Patch v1

Before use variable - found as an index, to check whether it is small then 0 first.

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 700860 [details] [diff] [review]
Patch v1

Review of attachment 700860 [details] [diff] [review]:
-----------------------------------------------------------------

nice catch

Comment 3

[Marco Chen [:mchen]]

Attachment: Patch Checkin-Version

1. Add reviewer.
2. Wait for try.
https://tbpl.mozilla.org/?tree=Try&rev=099f53085d4b

Comment 4

[Marco Chen [:mchen]]

All green in try.
https://tbpl.mozilla.org/?tree=Try&rev=099f53085d4b

Comment 5

[Jacek Caban]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e7dc5bede82

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3e7dc5bede82