829510 - When a contact name has no name and no lastname we show an empty string in the call log

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Etienne Segonzac (:etienne)]

STR where added here: bug 808794

Opening a new bug since the STR is different from the original one of bug 808794.

Comment 1

[Etienne Segonzac (:etienne)]

STR: bug 808794 comment 10

Comment 2

[David Scravaglieri [:scravag]]

We would take a patch for that.

Comment 3

[Etienne Segonzac (:etienne)]

Whoops, thought it was a blocking-basecamp bug.

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

This bug affects not only the call log but also the incoming and outcoming ;-) Solving it right away! :-)

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Screenshot.

Although this was discussed here: https://bugzilla.mozilla.org/show_bug.cgi?id=808794 , maybe we should rethink the information shown in the Call Log when there are contacts with no name. We may end up with something such as the information shown in this screenshot. In this screenshot, the first and second entries correspond to distinct phone numbers and contacts with no name assigned. Maybe we could show the phone number itself, since the existence of an associated contact can be deduced by the type of phone ("Mobile").

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Of course, the text shown should be "Unknown" instead of "Unknown number" as stated in the wireframes. Anyhow, the problem is the same ;-)

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Contacts screenshot.

BTW, this is what we show in Contacts when there are contacts with no name assigned ;-) Just in case it helps to make a decision.

Comment 9

[ayman maat :maat]

After review it is clear that there is a degree of realignment required between the information associated to a contact, and the information we display in the call log, SMS log and the contact list. I am putting together a matrix to clarify and will post when it is done.

Comment 10

[ayman maat :maat]

RFI to self to post matrix of correlation between information associated to a contact and information displayed in contact list, call log and SMS log

Comment 11

[Alex Keybl [:akeybl]]

This is a UX-P2 and is not a critical fix.

Comment 12

[ayman maat :maat]

this is related to Bug 819122

Comment 13

[ayman maat :maat]

(In reply to Alex Keybl [:akeybl] from comment #11)
> This is a UX-P2 and is not a critical fix.

moving this to UX-P1 and renomming tef? as there are consistency issues between the call log and the contacts list if this is not addressed which make information delivery inconsistant and therefore consumption harder.

Outline solution following...

Comment 14

[ayman maat :maat]

We need to align the presentation of a contacts information within the call log with that of the contact list. 
So to quick summarize… 

***scenario 1***

contact in contact list has: 
- firstname = yes 
- lastname = yes 
- company name = yes 

output in FirstName/LastName field in call log = firstname lastname


***scenario 2***

contact in contact list has: 
- firstname = no 
- lastname = no 
- company name = yes 

output in FirstName/LastName field in call log = company name


***scenario 3***

contact in contact list has: 
- firstname = no 
- lastname = no 
- company name = no 

output in FirstName/LastName field in call log = phone number called or received.


***scenario 4***

contact is not in contact list: 

output in FirstName/LastName field in call log = phone number called or received.

Comment 15

[Alex Keybl [:akeybl]]

We'll fix this for v1.x, at which point consistency fixes will be more appropriate. That's what tracking-b2g18:+ is denoting.

Comment 16

[Germán Toro del Valle (:gtorodelvalle)]

Hi Ayman, just to confirm it, in case there is firstname OR lastname, we just show it, right? Thanks!

Comment 17

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

Just made a comment on github

thanks :)

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 706460 [details] [diff] [review]
Associated PR.

Approving for v1-train so this goes into 1.0.1

Comment 20

[Germán Toro del Valle (:gtorodelvalle)]

Suggestion included in the code ;-) Thanks Francisco! :-)

(In reply to Francisco Jordano [:arcturus] from comment #18)
> Just made a comment on github
> 
> thanks :)

Comment 21

[Francisco Jordano [:arcturus] [:francisco]]

German you have the a+ and the r+ please merge :)

Comment 22

[Germán Toro del Valle (:gtorodelvalle)]

Merged! Thanks!

Comment 23

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 0caa5b6d855d497aa5f65fa80fbdf0f988d70a2b

Comment 24

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1