829520 - [Email] Folder sorting breaks the displayed folder hiearchy.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Pin Zhang [:pzhang] (inactive)]

Attachment: Local folders

The sub-folders under "Sent" are displayed as the sub-folders of "Junk" in the Email app.

Comment 1

[Pin Zhang [:pzhang] (inactive)]

Attachment: Folders in Hotmail

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Folders are stored in a flat list that is sorted on the composite key:
[account id, folder type priority, folder path]

Hierarchy is maintained within a folder type priority value, but the problem is that child folders do not inherit the folder type of their parents.

Options to avoid this problem are to:
- Have child folders inherit their parent's priority.
- Have the sort key always maintain hierarchy by sorting on an augmented folder path where each path segment is prefixed by the priority of that folder.  This is not entirely straightforward because the path is currently a flattened string with no meta-data.
- Use a tree structure and sort the contents of the tree.  This would require some internal rep changes.

Comment 3

[ayman maat :maat]

[TEF_REQ] as Feature required for TEF build.

Comment 4

[Andrew Overholt [:overholt]]

Who can take this?  Jim?  Andrew?

Comment 5

[Jim Porter (:squib)]

Sure, I can take this.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

It has been decided that the UX bugs will track, not block for v1.0.1 and we'll consider uplift but potentially target v1.1 depending on risk/reward.

Comment 7

[Dietrich Ayala (:dietrich)]

Hey Jim, when do you expect to have a fix for this?

Comment 8

[Jim Porter (:squib)]

In a day or two, I expect. I had gotten pulled off this to work on the music app for a bit, but now I'm back to focusing on this.

Comment 9

[Jim Porter (:squib)]

In-progress PR up: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/125

Things basically work for ActiveSync, but I haven't run tests, nor have I written any new tests yet. I also haven't fixed IMAP yet. Still, the interesting part (fixing the sort function) should be done.

Comment 10

[[:fabrice] Fabrice Desré]

Why are we spending time on this *now* ?

Comment 11

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Fabrice Desré [:fabrice] from comment #10)
> Why are we spending time on this *now* ?

It's "[TEF UX Critical]"; we were directed to work in this priority: shira+, tef+, TEF UX critical, v1.1 features.

Comment 12

[Jim Porter (:squib)]

Just a quick update for those following along: the code changes are done, and I'm just writing unit tests now. I should be totally finished this evening.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: Bugs marked status-b2g18: affected after 2/13 branching of v1.0.1 are now also status-b2g18-v1.0.1: affected

Comment 14

[Jim Porter (:squib)]

Attachment: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/125

This is ready for review now.

Comment 15

[Jim Porter (:squib)]

Checked in: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/125
            https://github.com/mozilla-b2g/gaia/pull/8219

Comment 16

[Jim Porter (:squib)]

Comment on attachment 714169 [details] [review]
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/125

(r+ from asuth over IRC)

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 2ebf7c3cc1addf0b46a6d7fa865c7c541c220065 as:
v1-train: 9abda2f7e31343519673a1cad2ce7657b47e2728

Comment 18

[Julien Wajsberg [:julienw]]

Was landed in v1.0.1 as part of Bug 851124 big uplift.
Will land (again) in v1-train tomorrow at the latest too.

Comment 19

[Julien Wajsberg [:julienw]]

Landed in v1-train as part of Bug 851124 big uplift.