[Email] Folder sorting breaks the displayed folder hiearchy.



Firefox OS
5 years ago
4 years ago


(Reporter: pzhang, Assigned: squib)



Firefox Tracking Flags

(blocking-b2g:-, b2g18+ fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)


(Whiteboard: interaction [UX-P1], [TEF_REQ], PRODUCT-FIXFEATURE, [TEF UX Critical])


(3 attachments)



5 years ago
Created attachment 700973 [details]
Local folders

The sub-folders under "Sent" are displayed as the sub-folders of "Junk" in the Email app.

Comment 1

5 years ago
Created attachment 700974 [details]
Folders in Hotmail
Folders are stored in a flat list that is sorted on the composite key:
[account id, folder type priority, folder path]

Hierarchy is maintained within a folder type priority value, but the problem is that child folders do not inherit the folder type of their parents.

Options to avoid this problem are to:
- Have child folders inherit their parent's priority.
- Have the sort key always maintain hierarchy by sorting on an augmented folder path where each path segment is prefixed by the priority of that folder.  This is not entirely straightforward because the path is currently a flattened string with no meta-data.
- Use a tree structure and sort the contents of the tree.  This would require some internal rep changes.
Summary: [Email] The structure of the local folders are inconsistent with the folders displayed in the Hotmail website. → [Email] Folder sorting breaks the displayed folder hiearchy.

Comment 3

5 years ago
[TEF_REQ] as Feature required for TEF build.
Whiteboard: interaction [UX-P1], [TEF_REQ]


5 years ago
Whiteboard: interaction [UX-P1], [TEF_REQ] → interaction [UX-P1], [TEF_REQ], PRODUCT-FIXFEATURE
Whiteboard: interaction [UX-P1], [TEF_REQ], PRODUCT-FIXFEATURE → interaction [UX-P1], [TEF_REQ], PRODUCT-FIXFEATURE, [TEF UX Critical]
blocking-b2g: --- → tef?
blocking-b2g: tef? → tef+
Who can take this?  Jim?  Andrew?

Comment 5

5 years ago
Sure, I can take this.
Assignee: nobody → squibblyflabbetydoo


5 years ago
It has been decided that the UX bugs will track, not block for v1.0.1 and we'll consider uplift but potentially target v1.1 depending on risk/reward.
blocking-b2g: tef+ → -
status-b2g18: --- → affected
status-b2g18-v1.0.0: --- → wontfix
tracking-b2g18: --- → +
Hey Jim, when do you expect to have a fix for this?

Comment 8

5 years ago
In a day or two, I expect. I had gotten pulled off this to work on the music app for a bit, but now I'm back to focusing on this.

Comment 9

5 years ago
In-progress PR up: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/125

Things basically work for ActiveSync, but I haven't run tests, nor have I written any new tests yet. I also haven't fixed IMAP yet. Still, the interesting part (fixing the sort function) should be done.
Why are we spending time on this *now* ?
(In reply to Fabrice Desré [:fabrice] from comment #10)
> Why are we spending time on this *now* ?

It's "[TEF UX Critical]"; we were directed to work in this priority: shira+, tef+, TEF UX critical, v1.1 features.

Comment 12

5 years ago
Just a quick update for those following along: the code changes are done, and I'm just writing unit tests now. I should be totally finished this evening.
Batch edit: Bugs marked status-b2g18: affected after 2/13 branching of v1.0.1 are now also status-b2g18-v1.0.1: affected
status-b2g18-v1.0.1: --- → affected

Comment 14

5 years ago
Created attachment 714169 [details] [review]

This is ready for review now.
Attachment #714169 - Flags: review?(bugmail)

Comment 15

5 years ago
Checked in: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/125
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 16

5 years ago
Comment on attachment 714169 [details] [review]

(r+ from asuth over IRC)
Attachment #714169 - Flags: review?(bugmail) → review+
Uplifted commit 2ebf7c3cc1addf0b46a6d7fa865c7c541c220065 as:
v1-train: 9abda2f7e31343519673a1cad2ce7657b47e2728
status-b2g18: affected → fixed
Was landed in v1.0.1 as part of Bug 851124 big uplift.
Will land (again) in v1-train tomorrow at the latest too.
status-b2g18-v1.0.1: affected → fixed
Landed in v1-train as part of Bug 851124 big uplift.
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.