829562 - Bad logic to select alarm-starting or alarm-select

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Guillermo López :willyaranda (probably SLOW response)]

On alarm.js, line 64:

// TODO: verify this is all we need to handle.
var type = (begins < now) ? 'alarm-starting' : 'alarm-started';

and 

# alarms
alarm-starting={{title}} started {{distance}}
alarm-started={{title}} starting in {{distance}}

The ternary if has switched values (if begins<now, it means that the event has started), but it's corrected on strings.

This should not block, but requesting just in case.

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Adding l10n folks as this might require a minor string change and bump.

Comment 2

[Kevin Grandon :kgrandon]

Should be easy enough to clean up, not sure if it's worth landing at this time because it appears there would be zero functionality changes and more of a clean-up issue.

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Don't think this needs to go for v1, but here's a pull request anyway.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 702187 [details]
Github pull request pointer

James - if you have nothing better to do take a minute and review this silly patch. Thanks!

Comment 5

[ayman maat :maat]

[TEF_REQ] as Feature required for TEF build.

Comment 6

[Kevin Grandon :kgrandon]

Just going through some old bugs and landed this minor fix. https://github.com/mozilla-b2g/gaia/commit/d4abaeae66db38cad25da0bff44aaddd4634aa0c

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit d4abaeae66db38cad25da0bff44aaddd4634aa0c as:
v1-train: d624469787dbd6f24ad20c7abb76721854b70b81