829571 - Retina buttons are wrongly sized

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: sshot

I'm not sure if that's expected but download buttons on retina to me look too big... wonder if we messed up something with defining their size.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

so, the problem is that the images on the buttons are set with list-style-image and I'm not sure we can limit the size of that... I suppose we may limit the size of the buttons though.

Comment 2

[Stephen Horlander [:shorlander]]

Comment on attachment 701039 [details]
sshot

Yeah, it's not supposed to look like that :)

I think as long as the dimensions are specified then referencing the @2x image in a media-query should "just work".

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 701135 [details] [diff] [review]
patch v1.0

Looks good on the Retina MacBook I just tested with. Thanks!

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/89b72b0cda19

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 701135 [details] [diff] [review]
patch v1.0

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Downloads panel feature
User impact if declined: giant buttons on retina
Testing completed (on m-c, etc.): m-i
Risk to taking this patch (and alternatives if risky): minimal and limited to feature
String or UUID changes made by this patch: none

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f188e913bd77

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/89b72b0cda19

Comment 9

[u279076]

This doesn't look completely fixed, see bug 898473.