829653 - The gstreamer back-end is not correctly hooked to configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

I'm getting build errors here: <http://mxr.mozilla.org/mozilla-central/source/content/media/gstreamer/GStreamerReader.h#8> because of the missing include file.  I have gst.h in the following locations:

$ find /usr/include | grep gst.h
/usr/include/gst.h
/usr/include/gstreamer-0.10/gst/gstchildproxy.h
/usr/include/gstreamer-0.10/gst/gstghostpad.h
/usr/include/gstreamer-0.10/gst/gst.h
/usr/include/gstreamer-0.10/gst/check/gstcheck.h

Seems like --enable-gstreamer should put the correct include path in CFLAGS using pkg-config or something...

Comment 1

[Alessandro Decina]

Attachment: fix

This fixes the build. Note that I had to use OS_CXXFLAGS in content/media/Makefile.in since CXXFLAGS didn't seem to work, no idea why.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Alessandro Decina from comment #1)
> Created attachment 721610 [details]
> fix
> 
> This fixes the build. Note that I had to use OS_CXXFLAGS in
> content/media/Makefile.in since CXXFLAGS didn't seem to work, no idea why.

Sorry for leaving such a mess with bug 834172. I can't really test with gstreamer, so thank you for taking care of the problem.

Comment 4

[Oleg Romashin (:romaxa)]

Tested, and it works ok with this fix

Comment 5

[Walter Meinl]

(In reply to Alessandro Decina from comment #1)
> Created attachment 721610 [details]
> fix
> 
> This fixes the build. Note that I had to use OS_CXXFLAGS in
> content/media/Makefile.in since CXXFLAGS didn't seem to work, no idea why.

when you move ifdef MOZ_GSTREAMER below "include $(topsrcdir)/config/rules.mk" it works with CXXFLAGS

Comment 6

[cajbir (:cajbir)]

Comment on attachment 721610 [details]
fix

I assume this isn't needed anymore since the DecoderTraits patch seems to already be in the tree and the CXXFLAGS bit after the rules.mk include is there too.

Comment 7

[Alex Xu]

Works for me on m-c changeset 124324 (current tip).

Comment 8

[Alessandro Decina]

Confirmed, I think the bug can be closed now