Closed Bug 829770 Opened 10 years ago Closed 9 years ago

Ensure Services.common spinning callback technique plays well with WinRT backend

Categories

(Firefox for Metro Graveyard :: Sync, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: jimm, Unassigned)

References

Details

(Whiteboard: [sync:metro])

Spun off from bug 809171. See bug 774779. We need to be sure the winrt backend is working ok with the internal loop.

http://mxr.mozilla.org/mozilla-central/source/services/common/async.js#89
Note that we won't have addressed Sync's event loop spinning until probably the end of Q1, maybe later, and it's possible we won't be able to eliminate all uses of it.

Also note that some other code -- e.g., the current version of Firefox Health Report -- spins the event loop using both this technique and this precise code.

If this bug involves work that isn't Metro-specific -- that is, if it touches /services/common -- please move it to Mozilla Services :: Common and explain the issue.

Finally, did you mean to block Bug 600059, or depend on it?
Summary: Insure Weave.sync() dispatch loop is playing well with winrt backend → Ensure Services.common spinning callback technique plays well with WinRT backend
Whiteboard: [sync:metro]
(In reply to Richard Newman [:rnewman] from comment #1)
> Note that we won't have addressed Sync's event loop spinning until probably
> the end of Q1, maybe later, and it's possible we won't be able to eliminate
> all uses of it.
> 
> Also note that some other code -- e.g., the current version of Firefox
> Health Report -- spins the event loop using both this technique and this
> precise code.
> 
> If this bug involves work that isn't Metro-specific -- that is, if it
> touches /services/common -- please move it to Mozilla Services :: Common and
> explain the issue.

Thanks for the info.

> Finally, did you mean to block Bug 600059, or depend on it?

Neither, I punched in the wrong bug number.
Blocks: metro-sync
No longer blocks: 600059
Blocks: 833126
Blocks: 831615
No longer blocks: metro-sync
Blocks: 849312
No longer blocks: 831615
Component: General → Sync
OS: Windows 7 → Windows 8 Metro
No longer blocks: 833126
I've been testing message processing quite a bit and so far haven't seen any issues.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.