Closed
Bug 829773
Opened 12 years ago
Closed 12 years ago
mozcrash should return sooner if there are no minidumps to process
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
Details
Attachments
(1 file)
|
1.70 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We do a few things before checking for number of minidumps, that are irrelevant if we end up not finding any. We should move the minidump check earlier.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #701302 -
Flags: review?(ted)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 701302 [details] [diff] [review]
Patch v1
Review of attachment 701302 [details] [diff] [review]:
-----------------------------------------------------------------
::: mozcrash/mozcrash/mozcrash.py
@@ +71,5 @@
>
> Returns True if any minidumps were found, False otherwise.
> """
> + dumps = glob.glob(os.path.join(dump_directory, '*.dmp'))
> + if len(dumps) == 0:
You can just change this to "if not dumps:" while you're here.
@@ +89,1 @@
> remove_symbols = False
nuke this trailing space while you're at it.
Attachment #701302 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•