82980 - Images inlined with <EMBED> prompt for a plugin download

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Steve]

To reproduce:

  Visit http://www.w3.org/Graphics/PNG/Inline-embed.html

Result:

  Popup: "This page contains information of type (image/png) that can only
          viewed with the appropriate plugin ..."

I have also tried this with jpeg and the result is the same.  Shouldn't
imagelib/libpr0n be able to handle these natively?

Comment 1

[Steve]

Note: Seen on post-0.9.1-freeze linux CVS build and W95 0.9 release.

Comment 2

[doctor__j]

Happens on Win32 build 2001052708 too.

Comment 3

[Stuart Parmenter]

I'm going to reassign this to plugins.... I expect the plugin object frame 
should try and create an image frame inside if its an image.

Comment 4

[av (gone)]

Attachment: patch to fix the problem -- first try

Comment 5

[av (gone)]

The attached patch fixes the original problem but there is still remaining 
issue. Somehow, <p align="center"> doesn't work for the embed tag. It works for 
other tags which trigger the creation of the object frame, so that the following 
works fine:

<p align="center"><img src="test.gif">
as well as
<p aling="center"><object data="test.gif"></object>

but this does not center the image:

<p align="center"><embed src="test.gif">

Adding peterl and karnaze.

Comment 6

[av (gone)]

Just one more observation: <center>...</center> pair works fine.

Comment 7

[Steve]

The patch works for me with images, but doesn't work with <embed>ed SVG graphics.

Compare embedded v. <embed> at 

  http://www.skeeter-s.com/svg/mozilly.xml

Comment 8

[av (gone)]

SVG graphics is not natively supported, is it? What is wrong on this latest page 
should probably be filed separately against XML.

Comment 9

[Chase Tingley]

*** Bug 89572 has been marked as a duplicate of this bug. ***

Comment 10

[Peter Lubczynski]

r=peterl on Andrei's patch. 

The centering problem is another bug, but you should try to get this in.

Comment 11

[Marc Attinasi]

sr=attinasi

Comment 12

[av (gone)]

Checked in.

Comment 13

[shrirang khanzode]

works on all plfs now.verif.