Last Comment Bug 829840 - [traceback] Cannot submit a paid app of price 0.00
: [traceback] Cannot submit a paid app of price 0.00
Status: VERIFIED FIXED
:
Product: Marketplace
Classification: Server Software
Component: Payments/Refunds (show other bugs)
: 1.0
: x86 Mac OS X
: P1 normal (vote)
: 2013-01-17
Assigned To: Matt Basta [:basta]
:
:
Mentors:
Depends on:
Blocks: marketplace-payments
  Show dependency treegraph
 
Reported: 2013-01-11 16:23 PST by Kumar McMillan [:kumar] (needinfo all the things)
Modified: 2013-01-17 13:12 PST (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description Kumar McMillan [:kumar] (needinfo all the things) 2013-01-11 16:23:49 PST
STR
- set an app to paid
- choose $0.00
- add a bank account
- click save

We get this error in solitude:

/bango/premium/: BangoError PRICE_ZERO_FOR_NON_FREE_ACCESS_MODEL: The price cannot be zero when the supplied access model is not 'free'
  File "/data/www/payments-dev.allizom.org/solitude/lib/bango/resources/cached.py", line 48, in obj_create
    resp = getattr(get_client(), self._meta.simple_api)(form.bango_data)

  File "/data/www/payments-dev.allizom.org/solitude/lib/bango/client.py", line 83, in call
    self.is_error(response.responseCode, response.responseMessage)

  File "/data/www/payments-dev.allizom.org/solitude/lib/bango/client.py", line 96, in is_error
    raise BangoError(code, message) 

http://sentry.dmz.phx1.mozilla.com/payments-dev/group/10851/
Comment 1 Andy McKay [:andym] 2013-01-11 16:59:43 PST
http://sentry.dmz.phx1.mozilla.com/payments-dev/group/10851/

BangoError PRICE_ZERO_FOR_NON_FREE_ACCESS_MODEL: The price cannot be zero when the supplied access model is not 'free'
Comment 2 Andy McKay [:andym] 2013-01-11 17:14:04 PST
Zamboni is calling make_premium with the initial price of zero. My guess is if the app is paid but 0.00, we should call UpdateAccessModelFree. We could do all this at the solitude level. We haven't addressed updating the access model yet and changing prices.
Comment 3 Kumar McMillan [:kumar] (needinfo all the things) 2013-01-14 14:19:35 PST
If the app is free, we don't need to call MakePremium() at all. We don't need to send free products through Bango's system, we have our own metrics. However, we do need a solitude product + secret for in-app payments to work.
Comment 4 Matt Basta [:basta] 2013-01-14 15:08:00 PST
https://github.com/mozilla/zamboni/commit/8f7d719f119ee4598fffcadd4ca3a3b5c12e3992

I'll file a bug to add support for the endpoint to keep Solitude in sync with zamboni for the price.
Comment 5 krupa raj[:krupa] 2013-01-17 13:12:06 PST
Having an app with in-app payments with price to tier worked fine @ https://marketplace-dev.allizom.org/developers/app/test-app-fawn129/payments/

Note You need to log in before you can comment on or make changes to this bug.