Bugzilla/Install/Requirements.pm no longer uses Safe

RESOLVED FIXED in Bugzilla 4.4

Status

()

Bugzilla
Bugzilla-General
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

Bugzilla 4.4
Bug Flags:
approval +
approval4.4 +

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 701378 [details] [diff] [review]
patch, v1

The Safe module is no longer used in Bugzilla/Install/Requirements.pm since Bugzilla 3.6, see bug 430014, but we still load this module all the time. As I mentioned in bug 696541 comment 0, Safe.pm is a bit slow to load. In my testing, removing this call saves us 50 ms.
Attachment #701378 - Flags: review?(glob)
Comment on attachment 701378 [details] [diff] [review]
patch, v1

> In my testing, removing this call saves us 50 ms.

interesting, because Bugzilla.pm always loads Safe, as does Bugzilla/Install/Localconfig and Bugzilla/DB/Schema.  i wouldn't have expected to see a perf gain by removing a duplicated 'use'.

regardless, it isn't used by the module, so should be removed.
r=glob
Attachment #701378 - Flags: review?(glob) → review+
(Assignee)

Updated

5 years ago
Flags: approval4.4+
Flags: approval+
(Assignee)

Comment 2

5 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Install/Requirements.pm
Committed revision 8552.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/Install/Requirements.pm
Committed revision 8500.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.