Closed Bug 829852 Opened 11 years ago Closed 11 years ago

Bugzilla/Install/Requirements.pm no longer uses Safe

Categories

(Bugzilla :: Bugzilla-General, defect)

Product:
Bugzilla
Component:
Bugzilla-General
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.4

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file)

patch, v1
689 bytes, patch
glob
: review+
Details | Diff | Splinter Review
Attached patch patch, v1 — — Splinter Review 
The Safe module is no longer used in Bugzilla/Install/Requirements.pm since Bugzilla 3.6, see bug 430014, but we still load this module all the time. As I mentioned in bug 696541 comment 0, Safe.pm is a bit slow to load. In my testing, removing this call saves us 50 ms.
Attachment #701378 - Flags: review?(glob)
Comment on attachment 701378 [details] [diff] [review]
patch, v1

> In my testing, removing this call saves us 50 ms.

interesting, because Bugzilla.pm always loads Safe, as does Bugzilla/Install/Localconfig and Bugzilla/DB/Schema.  i wouldn't have expected to see a perf gain by removing a duplicated 'use'.

regardless, it isn't used by the module, so should be removed.
r=glob
Attachment #701378 - Flags: review?(glob) → review+
Flags: approval4.4+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Install/Requirements.pm
Committed revision 8552.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/Install/Requirements.pm
Committed revision 8500.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: