829913 - Error while closing web console.

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Girish Sharma [:Optimizer]]

Using the latest fx-team, I see this error when I try to close Web Console in undocked Toolbox :

Timestamp: 1/12/2013 5:08:52 PM
Error: TypeError: popupset is null: WC_destroy@resource:///modules/HUDService.jsm:367
WCP_destroy@resource:///modules/WebConsolePanel.jsm:65
TBOX_destroy@resource:///modules/devtools/Toolbox.jsm:609
EventEmitter_emit@resource:///modules/devtools/EventEmitter.jsm:100
WindowHost.prototype._boundUnload@resource:///modules/devtools/ToolboxHosts.jsm:228

Source File: resource:///modules/devtools/EventEmitter.jsm
Line: 105

Comment 1

[Girish Sharma [:Optimizer]]

If you open the toolbox docked, and then undock it, or do not undock it, then this error is not seen. But if you open the toolbox undocked, then you will see this error on closing of web console. And afterwards, toolbox won't open.

Comment 2

[Girish Sharma [:Optimizer]]

Also this :

Timestamp: 1/12/2013 5:26:12 PM
Error: TypeError: aOutputNode.scrollBoxObject is undefined
Source File: chrome://browser/content/devtools/webconsole.js
Line: 3845

Comment 3

[Mihai Sucan [:msucan]]

Regression caused by Bug 827083.

Comment 4

[Mihai Sucan [:msucan]]

Attachment: fix

The isLocalTab check wasn't sufficient - undocked toolboxes work with local tab targets. Now the browserWindow getter checks if the window is a browser window.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 701470 [details] [diff] [review]
fix

Review of attachment 701470 [details] [diff] [review]:
-----------------------------------------------------------------

Messy, but OK. I wish we had support for this kind of thing in the Target object.

Comment 6

[Mihai Sucan [:msucan]]

Thank you!

Landed:
https://hg.mozilla.org/integration/fx-team/rev/77190bcc870c

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/77190bcc870c