Pyflakes - mozcrash.py:31: undefined name 'self'

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Line corresponds to:
> for name in self._zipfile.namelist():

We don't specify self in the function declaration:
> def extractall(zip, path = None):

Comment 1

5 years ago
Guessing you're referring to the in-tree 0.3.1 version: http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozcrash/mozcrash/mozcrash.py#31

The upstream github and version 0.4 (released to pypi) now use mozfile for this functionality:
https://github.com/mozilla/mozbase/blob/master/mozcrash/mozcrash/mozcrash.py , https://github.com/mozilla/mozbase/commit/60605afa176c4a423cf8e9f33d6b2e517b671781

Luckily, this bug doesn't actually affect anything as 2.7 is required and so this code never gets hit.  We can bump the version in m-c if desired, but that should be a separate bug.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(In reply to Jeff Hammel [:jhammel] from comment #1)
> Guessing you're referring to the in-tree 0.3.1 version:
> http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozcrash/
> mozcrash/mozcrash.py#31

No, I have mozbase checked out (for my recent mozcrash and mozlog patches) - my repo was just a day out of sync when I filed the bug, so didn't have the changes from bug 827600.
You need to log in before you can comment on or make changes to this bug.