829914 - Pyflakes - mozcrash.py:31: undefined name 'self'

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Ed Morley [:emorley]]

Line corresponds to:
> for name in self._zipfile.namelist():

We don't specify self in the function declaration:
> def extractall(zip, path = None):

Comment 1

[Jeff Hammel]

Guessing you're referring to the in-tree 0.3.1 version: http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozcrash/mozcrash/mozcrash.py#31

The upstream github and version 0.4 (released to pypi) now use mozfile for this functionality:
https://github.com/mozilla/mozbase/blob/master/mozcrash/mozcrash/mozcrash.py , https://github.com/mozilla/mozbase/commit/60605afa176c4a423cf8e9f33d6b2e517b671781

Luckily, this bug doesn't actually affect anything as 2.7 is required and so this code never gets hit.  We can bump the version in m-c if desired, but that should be a separate bug.

Comment 2

[Ed Morley [:emorley]]

(In reply to Jeff Hammel [:jhammel] from comment #1)
> Guessing you're referring to the in-tree 0.3.1 version:
> http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozcrash/
> mozcrash/mozcrash.py#31

No, I have mozbase checked out (for my recent mozcrash and mozlog patches) - my repo was just a day out of sync when I filed the bug, so didn't have the changes from bug 827600.