Closed Bug 829962 Opened 7 years ago Closed 7 years ago

Lightning breaks mail toolbar delete button icon

Categories

(Calendar :: General, defect)

All
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: merike, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch β€” β€” Splinter Review
I see this only under Linux in Customize window. This patch is only the minimal change to fix the issue. Maybe we should think about a id change to be safe and no more affecting TB or SM. Maybe a id like button-delete-event (I know the button also deletes tasks) could be better.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #701482 - Flags: review?(philipp)
Comment on attachment 701482 [details] [diff] [review]
patch

Review of attachment 701482 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with an id change, I'd suggest button-delete-item or maybe button-delete-calitem. r+ for this patch too though.
Attachment #701482 - Flags: review?(philipp) → review+
Attached patch New ID (obsolete) β€” β€” Splinter Review
This patch changes the button ID. I've also added a migration code but it isn't working. Philipp, please can you check what's wrong? Best would be if it checks if button-delete is in the toolbar and only then exchanges the IDs.
Attachment #711403 - Flags: feedback?(philipp)
Comment on attachment 711403 [details] [diff] [review]
New ID

The code will not work since calendar-chrome-startup is loaded on the main window, not the event dialog. We would have to add extra code to the event dialog to migrate.

I missed the fact that this means migration code. Do you really think its worth it?
With the first patch we should also be safe. Please can you land it, I'm at work? should this also go to aurora/beta to stop breaking SM?
Attachment #701482 - Flags: approval-calendar-beta?(philipp)
Attachment #701482 - Flags: approval-calendar-aurora?(philipp)
Attachment #701482 - Flags: approval-calendar-beta?(philipp)
Attachment #701482 - Flags: approval-calendar-beta+
Attachment #701482 - Flags: approval-calendar-aurora?(philipp)
Attachment #701482 - Flags: approval-calendar-aurora+
Attachment #711403 - Attachment is obsolete: true
Attachment #711403 - Flags: feedback?(philipp)
Pushed to comm-central changeset 76972e8b8432
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.3
Backported to releases/comm-aurora changeset 82a84f2fa6c5
Target Milestone: 2.3 → 2.2
Backported to releases/comm-beta changeset d2c6e7722663
Target Milestone: 2.2 → 2.1
Are the other selectors in the modified file OK? Should e.g. '#button-delete[disabled="true"]:hover' NOT take the .cal-event-toolbarbutton class?
As I wrote in comment 1, this affected only the icon in customize window, and where is no disabled state and so no need to change this.
You need to log in before you can comment on or make changes to this bug.