Closed Bug 829990 Opened 13 years ago Closed 13 years ago

Tabzilla CSS broken in local installs

Categories

(Websites :: Tabzilla, defect)

Product:
Websites
Component:
Tabzilla
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pmac, Assigned: pmac)

Details

(Whiteboard: u=contributor c=tabzilla p=1)

Because we directly reference the old tabzilla URL in our templates instead of using {{ css('tabzilla') }}, the tabzilla.less file is never compiled (locally) to tabzilla.less.css, and thus appears broken[0]. We should figure out a way around this. I've heard this from 2 contributors now. I hadn't noticed it to this point as I've had a copy of tabzilla.less.css around for a while now. [0] https://vimeo.com/57264912
My local repo was fixed with this change: https://github.com/Elideb/bedrock/commit/ae1d14ced64bddf960cc546cea96939183c7986b bug 829990 - Tabzilla CSS broken in local installs Replaced <link href="/tabzilla/media/css/tabzilla.css" rel="stylesheet"> with {{ css('tabzilla') }} in templates/base.html and templates/base-resp.html. Created a PR 592 (https://github.com/mozilla/bedrock/pull/592)
Whiteboard: u=contributor p=1 → u=contributor c=CSS p=1
Assignee: nobody → pmac
Here's another shot at a solution. https://github.com/mozilla/bedrock/pull/595
Status: NEW → ASSIGNED
Whiteboard: u=contributor c=CSS p=1 → u=contributor c=tabzilla p=1
Pushed to master. Fixed.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: Bedrock → Tabzilla
Product: www.mozilla.org → Websites
Target Milestone: --- → 1.5
Sorry for the bugspam -- the Target Milestore was set unexpectedly.
Target Milestone: 1.5 → ---
You need to log in before you can comment on or make changes to this bug.