Closed Bug 830018 Opened 13 years ago Closed 13 years ago

Intermittent browser_profiler_controller.js, test_profiler_actor.js | application crashed [@ AddSharedLibraryInfoToStream]

Categories

(Core :: Gecko Profiler, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: heycam, Assigned: espindola)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Noticed this today, intermittently crashing on Windows and WinXP debug bc, due to a recently added MOZ_ASSERT. https://tbpl.mozilla.org/php/getParsedLog.php?id=18751191&tree=Mozilla-Inbound Assertion failure: breakpadId == oStream.str(), at e:/builds/moz2_slave/m-in-w32-dbg/build/tools/profiler/nsProfiler.cpp:140 Thread 0 (crashed) 0 xul.dll!AddSharedLibraryInfoToStream [nsProfiler.cpp:b0ebc1fe57e9 : 140 + 0x4e] eip = 0x02bff4c8 esp = 0x0012c4a0 ebp = 0x0012c65c ebx = 0x2442a001 esi = 0x2442a038 edi = 0x0355025c eax = 0x00000000 ecx = 0xc18f03b6 edx = 0x10361f48 efl = 0x00000216 Found by: given as instruction pointer in context 1 xul.dll!GetSharedLibraryInfoString() [nsProfiler.cpp:b0ebc1fe57e9 : 163 + 0x16] eip = 0x02bff6f4 esp = 0x0012c664 ebp = 0x0012c718 Found by: call frame info 2 xul.dll!TableTicker::BuildJSObject(JSAObjectBuilder &,JSCustomObject *) [TableTicker.cpp:b0ebc1fe57e9 : 692 + 0xa] eip = 0x02c01315 esp = 0x0012c720 ebp = 0x0012c758 Found by: call frame info 3 xul.dll!TableTicker::ToJSObject(JSContext *) [TableTicker.cpp:b0ebc1fe57e9 : 683 + 0xb] eip = 0x02c015e4 esp = 0x0012c760 ebp = 0x0012c780 Found by: call frame info 4 xul.dll!mozilla_sampler_get_profile_data(JSContext *) [TableTicker.cpp:b0ebc1fe57e9 : 1098 + 0x9] eip = 0x02c01706 esp = 0x0012c788 ebp = 0x0012c78c Found by: call frame info 5 xul.dll!nsProfiler::GetProfileData(JSContext *,JS::Value *) [nsProfiler.cpp:b0ebc1fe57e9 : 179 + 0x7] eip = 0x02bfeb3b esp = 0x0012c794 ebp = 0x0012c798 Found by: call frame info 6 xul.dll!NS_InvokeByIndex_P [xptcinvoke.cpp:b0ebc1fe57e9 : 70 + 0x2] eip = 0x030c871c esp = 0x0012c7a0 ebp = 0x0012c7b4 Found by: call frame info 7 xul.dll!CallMethodHelper::Invoke() [XPCWrappedNative.cpp:b0ebc1fe57e9 : 3085 + 0xe] eip = 0x028f88cb esp = 0x0012c7bc ebp = 0x0012c7e0 Found by: call frame info 8 xul.dll!CallMethodHelper::Call() [XPCWrappedNative.cpp:b0ebc1fe57e9 : 2419 + 0x6] eip = 0x028fdcbc esp = 0x0012c7d0 ebp = 0x0012c7e0
Rafael, can you check if this is related to your recent changes in bug 825701?
Assignee: nobody → respindola
Summary: Intermittent browser_profiler_controller.js | application crashed [@ AddSharedLibraryInfoToStream] → Intermittent browser_profiler_controller.js, test_profiler_actor.js | application crashed [@ AddSharedLibraryInfoToStream]
Actually, it certainly is since the assert is MOZ_ASSERT(breakpadId == oStream.str()); Are you maybe losing a leading 0 when serializing?
Attached patch patchSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=e15a6af72242 I am not sure if this is *the* bug, but it is *a* bug. I think this could fire the assert if a sample from a hang hits a library with a pdb age >= 10.
Attachment #701867 - Flags: review?(vdjeric)
Attachment #701867 - Flags: review?(vdjeric) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: