830055 - After devtools Toolbox UI changes landed, Element Hiding Helper no longer works with the Element Inspector

Status: RESOLVED WORKSFORME

(DevTools :: Inspector, defect)

Description

[timbugzilla]

Adblock Plus's Element Hiding Helper works with Firefox's Element Inspector - this makes selecting the correct element simple. After changes to the devtools Toolbox UI landed (in December, IIRC) this no longer works. 

This is the UI change that broke this functionality:

http://i.imgur.com/tAxiw.png

This is with the latest dev builds of ABP and EHH. I am using the nightly moz central win32 build of FF.

Comment 1

[Paul Rouget [:paul]]

Sorry, I don't understand. What is "Adblock Plus's Element Hiding Helper"? And how does it use the inspector? What should we do here?

Comment 2

[Matthias Versen [:Matti]]

Paul: I think he means https://addons.mozilla.org/en-US/firefox/addon/elemhidehelper/

Comment 3

[timbugzilla]

The functionality of that add-on is described here:

https://adblockplus.org/development-builds/using-page-inspector-in-firefox-10-and-higher-to-hide-elements

Comment 4

[Wladimir Palant]

Element Hiding Helper was listening to the inspector-opened notification and using InspectorUI API - both are completely gone now so it isn't surprising that the integration no longer works.

Comment 5

[Joe Walker [:jwalker]]

(In reply to Wladimir Palant from comment #4)
> Element Hiding Helper was listening to the inspector-opened notification and
> using InspectorUI API - both are completely gone now so it isn't surprising
> that the integration no longer works.

Could you point us to the code that uses the old API? I suspect the best thing for us to do is to work out some code that will work in both pre-FF20 and post-FF20.

Comment 6

[Wladimir Palant]

The code is here: https://hg.adblockplus.org/elemhidehelper/file/11c7334ead47/lib/inspectorObserver.js. I want to update it so that it works with the new API but didn't have time so far.

Comment 7

[Rob Campbell [:rc] (:robcee)]

from irc:

17:36 <@robcee> inspector code lives in here:
17:36 <@robcee> http://mxr.mozilla.org/mozilla-central/source/browser/devtools/inspector/
17:37 <@robcee> http://mxr.mozilla.org/mozilla-central/source/browser/devtools/inspector/inspector-panel.js#282
17:38 <@robcee> you should be able to listen to onNewSelection to get highlighter changes
17:39 < rudi95> i was thinking about just adding the toolbarbutton to the  chrome://browser/content/devtools/inspector/inspector.xul file on the fly, but i don't know if this is possible with the firefox API
17:39 <@robcee> you'd have to dig it out of the DOM
17:40 <@robcee> probably made somewhat easy by the gDevTools global we stick into the chrome window
17:40 <@robcee> http://mxr.mozilla.org/mozilla-central/source/browser/devtools/inspector/test/browser_inspector_highlighter.js#64
17:41 <@robcee> there's an example of how to listen for one of these things
17:41 <@robcee> http://mxr.mozilla.org/mozilla-central/source/browser/devtools/inspector/test/head.js#30

Comment 8

[Gingerbread Man]

This was fixed in Element Hiding Helper 1.3, released in late April.
https://hg.adblockplus.org/elemhidehelper/rev/5caecd1c33b1