830057 - [bluetooth][gallery] Icon missing for Bluetooth Transfer in gallery sharing options

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Parul Mathur]

Attachment: Sharing options screen with missing icon for Bluetooth Transfer

Test Environment:
Device: unagi phone
Build Identifier: 20130111230201
Update channel: nightly
Git commit info: 2013-11-11 15:13:02 df38c1
Gaia Version: 45a3196a5517
Gecko Version: 8f2ef4998b60

Steps to reproduce:
1. Launch the Gallery app and view an image.
2. Tap on the Share icon to bring up the "Share with:" screen.

Actual results:
Sharing options "E-Mail" and "Wallpaper" have icons but "Bluetooth Transfer" does not.
 
Expected results:
Sharing option "Bluetooth Transfer" should have an icon just like the others.

See screenshot attached.

Comment 1

[Walter Chen[:ypwalter][:wachen]]

There are two ways to share a file.

If you open up an image to see and then you tap on the "share icon" to share, the menu would come up with "Share with: EMail, Share Receiver, Twitter share, Wallpaper, Bluetooth Transfer, Image Uploader".

However, if you choose the "select icon", select two or more images, and then tap on "share icon", it will come up with "Share with: E-Mail, Share Receiver, Twitter share, and Image Uploader".

I will ask around.
But, for me, it works for me as for now.

Comment 2

[Walter Chen[:ypwalter][:wachen]]

Per bluetooth Gecko team, this is out of spec of v1 to send multiple files in sequence.

CCing Gina Yeh.

Comment 3

[[e-mail]]

Attachment: screenshot with bluetooth 30x30 icon

is it ok to just put settings_bluetooth.png(30x30) to present bluetooth sender icon (as screenshot), 
or would like to provide a new one for bluetooth sender in share menu?

Comment 4

[Eric Pang [:epang] UX]

(In reply to Fred Lin [:gasolin] from comment #3)
> Created attachment 726476 [details]
> screenshot with bluetooth 30x30 icon
> 
> is it ok to just put settings_bluetooth.png(30x30) to present bluetooth
> sender icon (as screenshot), 
> or would like to provide a new one for bluetooth sender in share menu?

Hi Fred, I've created 2 new icons one for 'Bluetooth Transfer' and the other for 'Image Uploader'.  Can you you please use these two new images.  I'll attach the icons and a mock up. Thx!

Comment 5

[Eric Pang [:epang] UX]

Attachment: Mock up with new share icons

Replace the icons for "Bluetooth Transfer' and 'Image Uploader'

Comment 6

[Eric Pang [:epang] UX]

Attachment: New Share Icons

Comment 7

[[e-mail]]

Attachment: Add new bluetooth share icon

add bluetooth icon for web sharing activity


Not take 'Image Uploader' in because the menu icon of 'Image Uploader' will still choose the default ‘120x120' icon. And to change it may not a high priority task since 'Image Uploader' is an test app.

Comment 8

[[e-mail], [e-mail]]

(In reply to Eric Pang [:epang] from comment #6)
> Created attachment 726732 [details]
> New Share Icons

Hi Eric,
The icon size is '30x30'. I feel concern about using it on high quality platform. Could we use '60x60' to sync with other app's icon? Or other thing which I miss to point out.

Comment 9

[[e-mail]]

Hi Eric,
If we decide to go for 60x60, please update system and homescreen icons as well.

Comment 10

[Eric Pang [:epang] UX]

Attachment: Bluetooth Transfer share icon 60x60

Hi Ian, I've attached the icon at 60x60.

Comment 11

[[e-mail], [e-mail]]

Comment on attachment 728081 [details]
Add new bluetooth share icon

It looks fine, r+.

Comment 12

[[e-mail]]

merged to master-gaia, 
https://github.com/mozilla-b2g/gaia/commit/412c325cd87692e38739642b7a204007c4ff151b

thanks!

Comment 13

[Eric Pang [:epang] UX]

(In reply to Fred Lin [:gasolin] from comment #9)
> Hi Eric,
> If we decide to go for 60x60, please update system and homescreen icons as
> well.

Hi Fred, 
I'm not clear on what you mean.  What update do I need to make for the homescreen and system icons.

Let me know, thanks!

Comment 14

[[e-mail]]

Eric,

currently 'system' and 'homescreen' icons are only for list in settings/permission list and use 30x30 icon, if high quality platform is in concern, maybe those icons needs some update as well.

Comment 15

[Eric Pang [:epang] UX]

(In reply to Fred Lin [:gasolin] from comment #14)
> Eric,
> 
> currently 'system' and 'homescreen' icons are only for list in
> settings/permission list and use 30x30 icon, if high quality platform is in
> concern, maybe those icons needs some update as well.

Fred, Is this something we need to look at doing now, or in the future?

Comment 16

[[e-mail]]

Eric, it's not an urgent quest.

Comment 17

[Walter Chen[:ypwalter][:wachen]]

verified fixed in 2013/04/17 build by unagi.

Comment 18

[John Hu [:johnhu][:johu][:醬糊小弟]]

This bug is marked as QE3 and need to be uplifted to v1-train. So, nominate it as leo?.

Comment 20

[leo.bugzilla.gecko]

In triage

Comment 21

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 412c325cd87692e38739642b7a204007c4ff151b to:
v1-train: cfb5813a83e1b98ec4b75b57e21b5641cd87f3c9

Comment 22

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: cfb5813a83e1b98ec4b75b57e21b5641cd87f3c9