830180 - Calendar events, that span 15 minutes (or less) are not displayed correctly in Day/Month view.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Mila Davydova]

Attachment: 15 min events Month View

Unagi, build ID:20130113070202
Calendar events, that span 15 minutes, within the same 30 minute period, are overlapping each other, which makes it difficult to view. 
Steps:
1. Install build ID: 20130113070202
2. Open Calendar app
3. Create 2 events that span 15 minutes each, within the same 30 minute period time 
a. 1st event spans 15 minutes (12:00pm-12:15pm)
b. 2nd event spans 15 minutes (12:15pm-12:30pm)
4. View the events in day/month view

Expected:
User is able to view the events and they are not overlapping each other

Actual:
Events are displayed, but they are overlapping each other, which makes it difficult to view.

Comment 1

[Mila Davydova]

Attachment: 15 min event Day View

Comment 2

[Jason Smith [:jsmith]]

Valid bug, polish though. Let's see what UX thinks.

Comment 3

[James Lal [:lightsofapollo]]

Hmm, this is a case where the code is doing the right thing but the intent is flawed we need a minimum height/position set for events that span < then 15 minutes. We handle 30 minute events by hiding location.

Comment 4

[Mila Davydova]

This issue still reproduces on Unagi device
Build ID: 20130311070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/aec2f0738fab
Gaia: 067c040f3f16d5660ab1e117abf0834f1509d6f3

Calendar events, that span 15 minutes, within the same 30 minute period, are overlapping each other.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking since this looks like a low risk polish fix that would be a nice user win.

Comment 6

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8875

Pointer to Github pull-request

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Done!

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 730809 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8875

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Two calendar events with one's end time equal to the other's start time.
User impact if declined: The UI breaks if you have two such events (one of them will cover part of the other).
Testing completed: Passed the calendar app unit tests, confirmed fix in firefox nightly, and on unagi device.
Risk to taking this patch (and alternatives if risky): Not sure.
String or UUID changes made by this patch:

Comment 10

[Kevin Grandon :kgrandon]

Risk to taking this patch (and alternatives if risky): Unlikely, but if anything regressed it looks like it would be related to event overlap. It should not be any more broken than it is today.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit f8621db86ae6380bca20f980a4c32403c1a18638 as:
v1-train: 1d25c43320b1b75dc778c1951e8bebc9951db2d3

Comment 12

[Natalya Kot [:nkot]]

Attachment: screenshot, day view

Jason, can you please take a look,
- it seems to me that this issue is not completely fixed,
not sure what exactly the patch was applied for, it definitely looks better now as the events are now displayed parallel and so cannot overlap each other, however, two events with a span less than 15 min still do not connect nicely as the 30 min events do, please see the attached screenshot

tested on Unagi running the following build:
Build  2013-04-12-070204
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/950db80b82cb
Gaia   54ab4ce3f9107d1624c18bed2a09ace6bbc6601f

- also,
the text font-size is too big to fit into 15 min (or less) event frame, 
if it is not covered in this bug then i probably will have to file another bug so it will get fixed as well (or maybe there is one already that i could not find...)

Comment 13

[Jason Smith [:jsmith]]

Can I see the screenshot here you are citing?

Comment 14

[Natalya Kot [:nkot]]

its on comment 12, attachment 737047 [details]

Comment 15

[Jason Smith [:jsmith]]

File a new bug for the 15 minute case in that screenshot.

Comment 16

[Natalya Kot [:nkot]]

Events than span 15 min and ones that span less than 15 min need some more polishing work, 
created two new bugs: bug 862102, and bug 862114

Comment 17

[Gareth Aye [:gaye] (back from PTO)]

The patch caused https://bugzilla.mozilla.org/show_bug.cgi?id=864398 so I'm reopening :/

Comment 18

[Jason Smith [:jsmith]]

bug 864398 is a followup. We typically track landings as a series of items that fall after each other.

The only reason we should reopen if something has landed is if you backout the patch on this bug.

Comment 19

[Jason Smith [:jsmith]]

Just to transfer info over - patch was backed out in https://github.com/mozilla-b2g/gaia/pull/9464.

Comment 20

[Stephany Wilkes]

Clearing the UX-P? as it is unclear, from the thread here, what UX is needed. Please re-add as necessary.

Comment 22

[Gareth Aye [:gaye] (back from PTO)]

Works in master.

Comment 23

[Harly Hsu[:harly]]

Will reply in 962445