830221 - Remove nsIDOMDOMImplementation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

It's used by 2 addons, but they both list a maxVersion of 3.6

Comment 1

[Alex Vincent [:WeirdAl]]

Peanut gallery here:  what's the rationale for this?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Removing no-longer-needed code.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 701677 [details] [diff] [review]
Patch

r=me if you've tested that trying to install those addons from AMO on a current build fails.

Comment 4

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d88715bba2ca

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d88715bba2ca

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

So we removed DOMImplementation?

https://bugzilla.mozilla.org/show_bug.cgi?id=796903#c10
https://bugzilla.mozilla.org/show_bug.cgi?id=796903#c14

https://groups.google.com/forum/?fromgroups=#!topic/mozilla.dev.apps.firefox/GFmju3r2GY4

Comment 7

[Boris Zbarsky [:bzbarsky]]

Hmm.  Binary addons can still use mozilla::dom::DOMImplementation.  But if you feel like making them do that is not reasonable then we do in fact need to back this out.  :(

Peter?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

How can binary addons use DOMImplementation?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Hmm.  I guess the main stumbling block is that CreateDocument is non-virtual?  Or is there something else I'm missing?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Yes, we need some way to create documents in binary addons.

Comment 11

[David Zbarsky (:dzbarsky)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ccc0d4c2ad6f

Comment 12

[David Zbarsky (:dzbarsky)]

Attachment: Backout patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Breaks some binary addons
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):  Low risk
String or UUID changes made by this patch: None

Comment 13

[Ed Morley [:emorley]]

(In reply to David Zbarsky (:dzbarsky) from comment #11)
> Backed out in
> https://hg.mozilla.org/integration/mozilla-inbound/rev/ccc0d4c2ad6f

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/ccc0d4c2ad6f

Comment 14

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fae605ea8ef7

Comment 15

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 830221 - Remove nsIDOMDOMImplementation.

Review commit: https://reviewboard.mozilla.org/r/219586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219586/

Comment 16

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8950359 [details]
Bug 830221 - Remove nsIDOMDOMImplementation.

https://reviewboard.mozilla.org/r/219586/#review225388

r=me, given that binary addons are no more.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e234a362e55
Remove nsIDOMDOMImplementation. r=bz

Comment 18

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5e234a362e55