Closed Bug 830231 Opened 7 years ago Closed 7 years ago

Remove nsIDOMDOM(Settable)TokenList

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

Details

Attachments

(1 file)

No description provided.
Attached patch PatchSplinter Review
There are only used by Firebug, which already has a workaround for new bindings.
Attachment #702111 - Flags: review?(bzbarsky)
Firebug's Arr.isArrayLike doesn't seem to have been fixed....  Am I missing something?
Oh, I see, it's just not called now.
Comment on attachment 702111 [details] [diff] [review]
Patch

Hmm.  Shouldn't SetValue be marked [Throws] and propagate exceptions from SetAttr?

r=me with that fixed.
Attachment #702111 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky (:bz) from comment #4)
> Comment on attachment 702111 [details] [diff] [review]
> Patch
> 
> Hmm.  Shouldn't SetValue be marked [Throws] and propagate exceptions from
> SetAttr?
> 

Yep, that was already broken and we don't have tests =(

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd642fb004e6
https://hg.mozilla.org/mozilla-central/rev/fd642fb004e6
https://hg.mozilla.org/mozilla-central/rev/81a519d21a1e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.