Created attachment 702111 [details] [diff] [review] Patch There are only used by Firebug, which already has a workaround for new bindings.
Attachment #702111 - Flags: review?(bzbarsky)
Firebug's Arr.isArrayLike doesn't seem to have been fixed.... Am I missing something?
Oh, I see, it's just not called now.
Comment on attachment 702111 [details] [diff] [review] Patch Hmm. Shouldn't SetValue be marked [Throws] and propagate exceptions from SetAttr? r=me with that fixed.
Attachment #702111 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky (:bz) from comment #4) > Comment on attachment 702111 [details] [diff] [review] > Patch > > Hmm. Shouldn't SetValue be marked [Throws] and propagate exceptions from > SetAttr? > Yep, that was already broken and we don't have tests =( https://hg.mozilla.org/integration/mozilla-inbound/rev/fd642fb004e6
This for some reason needed a clobber on Windows, eg: https://tbpl.mozilla.org/php/getParsedLog.php?id=18810700&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=18810345&tree=Mozilla-Inbound Modified the clobber file so people get warned as such: https://hg.mozilla.org/integration/mozilla-inbound/rev/81a519d21a1e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Depends on: 832011
You need to log in before you can comment on or make changes to this bug.