830231 - Remove nsIDOMDOM(Settable)TokenList

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

There are only used by Firebug, which already has a workaround for new bindings.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Firebug's Arr.isArrayLike doesn't seem to have been fixed....  Am I missing something?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Oh, I see, it's just not called now.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 702111 [details] [diff] [review]
Patch

Hmm.  Shouldn't SetValue be marked [Throws] and propagate exceptions from SetAttr?

r=me with that fixed.

Comment 5

[David Zbarsky (:dzbarsky)]

(In reply to Boris Zbarsky (:bz) from comment #4)
> Comment on attachment 702111 [details] [diff] [review]
> Patch
> 
> Hmm.  Shouldn't SetValue be marked [Throws] and propagate exceptions from
> SetAttr?
> 

Yep, that was already broken and we don't have tests =(

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd642fb004e6

Comment 6

[Ed Morley [:emorley]]

This for some reason needed a clobber on Windows, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=18810700&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=18810345&tree=Mozilla-Inbound

Modified the clobber file so people get warned as such:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81a519d21a1e

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fd642fb004e6
https://hg.mozilla.org/mozilla-central/rev/81a519d21a1e