Remove nsIDOMDOM(Settable)TokenList

RESOLVED FIXED in mozilla21

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 702111 [details] [diff] [review]
Patch

There are only used by Firebug, which already has a workaround for new bindings.
Attachment #702111 - Flags: review?(bzbarsky)
Firebug's Arr.isArrayLike doesn't seem to have been fixed....  Am I missing something?
Oh, I see, it's just not called now.
Comment on attachment 702111 [details] [diff] [review]
Patch

Hmm.  Shouldn't SetValue be marked [Throws] and propagate exceptions from SetAttr?

r=me with that fixed.
Attachment #702111 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 5

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #4)
> Comment on attachment 702111 [details] [diff] [review]
> Patch
> 
> Hmm.  Shouldn't SetValue be marked [Throws] and propagate exceptions from
> SetAttr?
> 

Yep, that was already broken and we don't have tests =(

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd642fb004e6

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/fd642fb004e6
https://hg.mozilla.org/mozilla-central/rev/81a519d21a1e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.