Closed Bug 830272 Opened 7 years ago Closed 6 years ago

[COST CONTROL] Balance threshold is not validated and can be 0

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:-, b2g18?)

RESOLVED FIXED
1.1 QE4 (15jul)
blocking-b2g -
Tracking Status
b2g18 ? ---

People

(Reporter: carlosmartinez, Assigned: salva)

Details

(Whiteboard: testrun 4, testrun 5.1, leorun3, leorun4)

Attachments

(1 file)

Tested in unagi with Gecko-1e1821a Gaia-9d4983b.

STR:
1-Insert a non configured prepaid VIVO SIM card
2-Pull down notification tray
3-Tap in the credit module
4-Select I´m prepaid, activate balance threshold, set internet report & remainders
5-Go to app settings
6-Insert a 0 as balance threshold

Expected result --> If you type a 0 as balance threshold some kind of error message should be shown

Actual result --> If you type a 0 as balance threshold, it´s saved without any problem
Whiteboard: testrun 4
Whiteboard: testrun 4 → testrun 4, testrun 5.1
Test case id:  #5449
Failing with Leo testrun3 build:

Test case id:#5449
Whiteboard: testrun 4, testrun 5.1 → testrun 4, testrun 5.1, leorun3
Whiteboard: testrun 4, testrun 5.1, leorun3 → testrun 4, testrun 5.1, leorun3, leorun4
Nomming, but with a question - if someone enters 0 by mistake, they will obviously be misinformed when that threshhold is immediately succeeded. In South America, they absolutely depend on the tracking app - as budgets are tight. Will the resulting confusion be a cause for a blocker?  Opinions please.
blocking-b2g: --- → leo?
Flags: needinfo?(salva)
I think we should push for leo+ as the constrain addition is very low risk and it resolves negative values as well (we are currently accepting negative values). Indeed, I'm providing the patch just right now to allow you notice the low impact of the solution.
Flags: needinfo?(salva)
Assignee: nobody → salva
Attachment #771991 - Flags: review?(francisco.jordano)
We wouldn't hold a release for this, it should get fixed and ride the trains.
blocking-b2g: leo? → -
Salva just added a comment on github, is not really important, but would like your input there.

Once answered r+ this :)
Priority: -- → P2
Target Milestone: --- → 1.1 QE4 (15jul)
Comment on attachment 771991 [details]
Adding constrains to avoid negative or zero values in balance threshold

Great job Salva!

Thanks for nice piece of work!
Attachment #771991 - Flags: review?(francisco.jordano) → review+
Master: c0e3f90f6efa4cacac548dff2d2cb486e14db440
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
This has not been uplifted to v1-train, so the problem persists in v1-train.
Check with Unagi device v1-train 07/17 build:
Gecko-2d17cfb
Gaia-c506c50
You need to log in before you can comment on or make changes to this bug.