830287 - [COST CONTROL] No error message is shown when trying to update balance while in airplane mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Tested in unagi with Gecko-1e1821a Gaia-9d4983b.

STR:
1-Insert a non configured prepaid VIVO SIM card
2-Long tap power button to activate airplane mode
3-Pull down notification tray
4-Tap in the credit module
5-Select I´m prepaid, activate balance threshold, set internet report & remainders
6-Try to update your balance

Expected result --> An error message should be shown "Airplane mode ON Airplane mode - balance update and top-up OFF In detail balance view"

Actual result --> Nothing is shown

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

QAWanted : check to make sure that airplane mode/mobile data off isn't bypassed.

Comment 2

[Carlos Martínez Toral [:carlosmartinez]]

With bypassed you mean that if when in airplane mode you can connect to the internet?

If that is what you mean, no, ni internet connection is available and I cannot place calls, so airplane mode is working fine.

Comment 3

[Salvador de la Puente González [:salva]]

Attachment: Added error for airplane mode and make errors be unified under an error matrix

Bug caused by (feature/regressing bug #): this one
User impact if declined: medium
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Salvador de la Puente González [:salva]]

Airplane mode is causing SIM state set to 'absent'. In order to try this patch, open CC application in a normal state with coverage signal and then, pass to airplane mode.

The SIM state issue should be filed as a bug if it does not exist.

Comment 5

[Marcelino Veiga Tuimil [:sonmarce]]

(In reply to Salvador de la Puente González [:salva] from comment #4)
> The SIM state issue should be filed as a bug if it does not exist.

Salva, do you mean we have to file a B2G bug to fix this bug?

Comment 6

[Salvador de la Puente González [:salva]]

(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #5)
> (In reply to Salvador de la Puente González [:salva] from comment #4)
> > The SIM state issue should be filed as a bug if it does not exist.
> 
> Salva, do you mean we have to file a B2G bug to fix this bug?

I think so but I did not file the bug myself because I was waiting to land this bug in order to show an easy STR.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 709036 [details]
Added error for airplane mode and make errors be unified under an error matrix

Nice work, tried on the phone and working perfectly.

Comment 8

[Salvador de la Puente González [:salva]]

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/7a6bd960c854e400a5b720e330fe74cb857721dd

Comment 9

[Salvador de la Puente González [:salva]]

Let me clarify comment #4. The STR reported in comment #1 was written before resolving bug #831274. As now the Cost Control application checks if SIM is absent before starting, the STR of comment #1 is not reproducible.

I opened a bug about this. It is bug #837755

Actual STR for this is:

1 - Insert any SIM
2 - Check there is no coverage issues nor in airplane mode
3 - Open Cost Control application
4 - Enable airplane mode
5 - Press update

Expected:
An explanation about we are in airplane mode

Current:
NOTE: now is solved so the expected behavior appears here but before this patch no message was shown.

Comment 10

[Marcelino Veiga Tuimil [:sonmarce]]

Just to clarify, this patch fixes the problem in Gaia, notifying you are in airplane mode. But there is a problem in Gecko, saying there is no SIM when you are in airplane mode. This is the bug 837755, that have to be fixed for Cost Control to work in all cases.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Does this involve late-l10n or are we re-using strings? That will affect our decision to approve here.

Comment 12

[Salvador de la Puente González [:salva]]

Reusing. Indeed the problem was the message was not shown, not the message did not exist.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 709036 [details]
Added error for airplane mode and make errors be unified under an error matrix

Thanks, approval.

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 765dc61e660ba34553fd55fd6f8c7ba7107d304e

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1

Comment 17

[Marcelino Veiga Tuimil [:sonmarce]]

The whole problem will be fixed after landing both bug 837755 and bug 836257 bugs (no extra work is needed in this bug).