830308 - Regression: Reader Mode busted

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Mark Capella [:capella]]

Not sure if this has been reported or is real .... need someone to confirm ... but I re-pulled central, popped all patches off MQ, uninstalled Nightly from my S3, rebuilt and re-installed and pressing the readermode book icon just stops at a blank page for me ...

See attached ...

Comment 1

[Mark Capella [:capella]]

Attachment: reader mode fail

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Any errors in logcat?

Comment 3

[Mark Capella [:capella]]

No - (should have mentioned)

Comment 4

[Aaron Train [:aaronmt]]

Same here, Galaxy Nexus (Android 4.2)

D/GeckoApp( 2709): State - 983041
D/GeckoApp( 2709): Got a document start event.
I/GeckoApp( 2709): Security Mode - unknown
I/GeckoToolbar( 2709): zerdatime 1123315 - Throbber stop
E/GeckoConsole( 2709): [JavaScript Warning: "Error in parsing value for 'list-style'.  Declaration dropped." {file: "chrome://browser/skin/aboutReader.css" line: 287 column: 15 source: "  list-style: disk !important;"}]
E/GeckoConsole( 2709): AboutReader: Init()
E/GeckoConsole( 2709): AboutReader: Feching toolbar, header and content notes from about:reader
E/GeckoConsole( 2709): [JavaScript Error: "NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]" {file: "chrome://browser/content/aboutReader.js" line: 68}]
D/GeckoApp( 2709): State - 786448
D/GeckoApp( 2709): Got a document stop event.

Comment 5

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d36a97058e39&tochange=f3b6bc4b2590

Guessing bug 800188.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

I believe the problem is actually in bug 826992. This adds a new pref to mobile/android/app/mobile.js, called browser.safebrowsing.id, like so:

+pref("browser.safebrowsing.id", "@MOZ_APP_UA_NAME@");

The @MOZ_APP_UA_NAME@ can includes quotes, which can cause the prefs loading to fail. In my objdir, the expansion is this:

pref("browser.safebrowsing.id", ""Firefox"");

Since the "reader.color_scheme" pref is one of the handful of prefs that occurs after this pref in the file, it doesn't get read in properly, causes aboutReader.js to thrown an exception, and causes reader mode to fail. It probably also causes failures for all of the other prefs after browser.safebrowsing.id in that file, they're just not as obvious.

Comment 7

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/mozilla-central/rev/b72d2af170aa

Comment 9

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 21.0a1 (2013-02-17)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1