Closed Bug 830308 Opened 8 years ago Closed 8 years ago

Regression: Reader Mode busted

Categories

(Firefox for Android Graveyard :: Reader View, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox19 unaffected, firefox20 unaffected, firefox21 verified)

VERIFIED FIXED
Firefox 21
Tracking Status
firefox19 --- unaffected
firefox20 --- unaffected
firefox21 --- verified

People

(Reporter: capella, Assigned: gcp)

References

Details

(Keywords: regression, reproducible)

Attachments

(1 file)

Not sure if this has been reported or is real .... need someone to confirm ... but I re-pulled central, popped all patches off MQ, uninstalled Nightly from my S3, rebuilt and re-installed and pressing the readermode book icon just stops at a blank page for me ...

See attached ...
Attached image reader mode fail
No - (should have mentioned)
Same here, Galaxy Nexus (Android 4.2)

D/GeckoApp( 2709): State - 983041
D/GeckoApp( 2709): Got a document start event.
I/GeckoApp( 2709): Security Mode - unknown
I/GeckoToolbar( 2709): zerdatime 1123315 - Throbber stop
E/GeckoConsole( 2709): [JavaScript Warning: "Error in parsing value for 'list-style'.  Declaration dropped." {file: "chrome://browser/skin/aboutReader.css" line: 287 column: 15 source: "  list-style: disk !important;"}]
E/GeckoConsole( 2709): AboutReader: Init()
E/GeckoConsole( 2709): AboutReader: Feching toolbar, header and content notes from about:reader
E/GeckoConsole( 2709): [JavaScript Error: "NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]" {file: "chrome://browser/content/aboutReader.js" line: 68}]
D/GeckoApp( 2709): State - 786448
D/GeckoApp( 2709): Got a document stop event.
tracking-fennec: --- → ?
OS: Windows 7 → Android
Hardware: x86_64 → ARM
Summary: Can't get to reader mode on S3 w/nightly → Regression: Reader Mode busted
Version: unspecified → Trunk
I believe the problem is actually in bug 826992. This adds a new pref to mobile/android/app/mobile.js, called browser.safebrowsing.id, like so:

+pref("browser.safebrowsing.id", "@MOZ_APP_UA_NAME@");

The @MOZ_APP_UA_NAME@ can includes quotes, which can cause the prefs loading to fail. In my objdir, the expansion is this:

pref("browser.safebrowsing.id", ""Firefox"");

Since the "reader.color_scheme" pref is one of the handful of prefs that occurs after this pref in the file, it doesn't get read in properly, causes aboutReader.js to thrown an exception, and causes reader mode to fail. It probably also causes failures for all of the other prefs after browser.safebrowsing.id in that file, they're just not as obvious.
Blocks: 826992
No longer blocks: 800188
https://hg.mozilla.org/mozilla-central/rev/b72d2af170aa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Duplicate of this bug: 829570
Assignee: nobody → gpascutto
Verified fixed on:
-build: Firefox for Android 21.0a1 (2013-02-17)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.