830348 - The validator failed to reflag dictionary.com's app for re-review when the appcache_path referenced pointed to a 404

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect)

Description

[Jason Smith [:jsmith]]

Apparently the validator failed to flag dictionary.com's app for re-review when the appcache_path referenced pointed to a 404. Andrew indicates that the manifest itself didn't change, but only the resource referenced by the appcache_path did. As a result, apparently we never caught the fact that the appcache referenced no longer existed. We need to make sure we're catching cases when the appcache_path changes to an invalid value - in this case, it went from a valid path to a 404.

Comment 1

[Matt Basta [:basta]]

What is the timeline for the error? I.e. When was the app 404ing?

Comment 2

[Andrew Williamson [:eviljeff]]

(In reply to Matt Basta [:basta] from comment #1)
> What is the timeline for the error? I.e. When was the app 404ing?

not sure... though even after hitting the refresh button next to the manifest (which should trigger an immediate revalidation iirc) there are no errors reported in the review log.

Comment 3

[Matt Basta [:basta]]

This should be corrected here:

https://github.com/mozilla/app-validator/commit/0920b5eab41eb7eda92857acc00fc26e13cf3551

I can't test this effectively locally (aside from writing unit tests that mock the scenario) because this is dependent on using the validator API with some very specific marketplace settings. It should be live on dev in a few, so it should be testable there.