830361 - [COST CONTROL] 3G data & Wifi data usage graphic is not correct

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Attachment: Data usage cycle configuration

Tested in unagi with Gecko-1e1821a Gaia-9d4983b.

STR:
1-Insert a non configured prepaid VIVO SIM card
2-Pull down notification tray
3-Configure data usage cycle (e.g. as weekly reseting on tuesday)
4-Open Data usage screen to see the graphic

Expected result --> Something similar to what we can find in the attached document

Actual result --> Start and end date of the billing cycle doesn´t make any sense, time division should be something like 6 lines to see one for each day in the week... etc.

Comment 1

[Carlos Martínez Toral [:carlosmartinez]]

Attachment: Data usage graphic

Comment 2

[Carlos Martínez Toral [:carlosmartinez]]

Attachment: Data usage wireframes V15

Comment 3

[Josh Carpenter [:jcarpenter]]

Marco or Ayman, can you chime in here?

Comment 4

[marcoc]

(In reply to Josh Carpenter [:jcarpenter] from comment #3)
> Marco or Ayman, can you chime in here?

To clarify the issue:

When the Settings of the billing cycle period and start date are modified, the Data Usage graph needs to change to reflect setting changes. Therefore:

**billing cycle**

- If the billing cycle period is Weekly: the graph should show 7 lines
- if the billing cycle period is Monthly: the graph should show a line for each day in the monthly period. 
- if the billing cycle period is Never: the graph should show a line for each day in the monthly period as well.
 

**start date**

- If the start date is changed and the billing cycle is set to Weekly: then the dates on the bottom of the graph need to update to show the new period. 
- If the start date is changed and the billing cycle is set to Monthly: the dates on the bottom of the graph need to update as well as the number of lines on the graph to show the new period

The current date should be identified within the graph. If the cycle ends in two days, then the current date should be located two days prior to the end go the graph.


**Never graph behavior**

- if the billing cycle is set to Never, and no data on usage is present, behavior would follow that of monthly, except that when current date reaches day 22 of month, graph dates adjust to mark passing of time.
- if the billing cycle is set to Never, and data on usage is already present in graph - graph should adjust monthly view so that current date is marked at day 22 of month. And graph dates adjust to mark passing of time.

Comment 5

[David Scravaglieri [:scravag]]

Looks correct although. Would take a patch to follow the wireframes.

Comment 6

[Salvador de la Puente González [:salva]]

Attachment: New behavior for X axis in charts

Bug caused by (feature/regressing bug #): this one
User impact if declined: moderate
Testing completed: yes
Risk to taking this patch (and alternatives if risky): medium

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 705340 [details]
New behavior for X axis in charts

Made some comments in the PR.

Thanks Salva!

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 705340 [details]
New behavior for X axis in charts

Good work!

Nice improvements, just checked in the phone and working like charm!

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 705340 [details]
New behavior for X axis in charts

We need this change in 1.0.1 for the correct behavior of the application.

a=me

Comment 10

[Salvador de la Puente González [:salva]]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/3cce620affb67b938ed699a27e67b84f1185d524

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 1dc2cd91a1923391512ca0195c5a8a07119294d7

Comment 13

[Salvador de la Puente González [:salva]]

Please, see:
https://bugzilla.mozilla.org/show_bug.cgi?id=837652#c6

Comment 14

[Salvador de la Puente González [:salva]]

Bug #837652 includes changes from this bug. If I merge that bug this will be included as well in the same patch. Please, consider nominating this as well. There is no a topic relation but a temporal dependency. Renominating...

Comment 15

[Salvador de la Puente González [:salva]]

Sorry, I can merge without including changes from this bug. It's done.

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1