830395 - Ugly focus ring around FHR "Learn More" link

Status: NEW

(Firefox :: General, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Screenshot

Started recent Nightly, got FHR notification bar, clicked "Choose What I Share".

The first "Learn More" has a dotted focus ring around it immediately upon opening.

My understanding (am I crazy?) what that these were only supposed to show up after a keyboard navigation. mconley has been battling a similar issue over in bug 819428... Did we regress something in general for this stuff? Or did it not ever actually work like I thought?

Comment 1

[Neil Deakin]

I only have the 'Firefox Health Report' when I open the dialog, but the link does not appear focused. Is there a way to get the notification to appear?

> My understanding (am I crazy?) what that these were only supposed to show up after a keyboard navigation.

On Mac, focus rings appear on any element that is focused. I don't see anything in that dialog's code that would cause the link to be focused though.

Comment 2

[Gregory Szorc [:gps]]

(In reply to Neil Deakin from comment #1)
> I only have the 'Firefox Health Report' when I open the dialog, but the link
> does not appear focused. Is there a way to get the notification to appear?

You can force the notification to appear by resetting the following prefs:

datareporting.policy.dataSubmissionPolicyAccepted
datareporting.policy.dataSubmissionPolicyNotifiedTime
datareporting.policy.dataSubmissionPolicyResponseTime
datareporting.policy.dataSubmissionPolicyResponseType

If you are on a fresh profile, subtract datareporting.policy.firstRunTime 12 * 60 * 60 * 1000 from the value and wait up to 60 seconds (I just decrement the 3rd digit by 1).

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I was able to get the notification to come up, but I've had no luck reproducing the focusring issue.

Comment 4

[Neil Deakin]

I got a notification bar, but couldn't reproduce the focusring issue either.

Comment 5

[Kamil Jozwiak [:kjozwiak]]

Attachment: "Learn More" under "Data Choices"

I can reproduce this issue 100% of the time using the latest Nightly build, I've seen this
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-04-10-03-02-00-mozilla-central/

I've reproduced the issue 100% of the time following the STR listed below. Basically, you open the preference window, close it and then re-open it again and you should see the focus ring around "Learn More". You can do the same thing with the "Sync" tab and "Manage" will have the focus ring around it.

* Attached two screenshots to illustrate the issue:

Steps to reproduce the issue:

1) Install the latest Nightly (use the build that's linked above)
2) Once installed, select the australis "Settings" menu
3) Select the "Preferences" icon
4) Select "Advanced" -> "Data Choices"
5) Close the "Preference" window and then re-open it again (you should be under the "Data Choices" category and "Learn More" will have the focus ring around it)
6) While you still have the "Preference" window open, switch over to the "Sync" tab and then close the "Preferences" window
6) Re-open the "Preferences" window again and you should be under the "Sync" category with "Manage" having the focus ring around it

Comment 6

[Kamil Jozwiak [:kjozwiak]]

Attachment: "Manage" under "Sync"