Closed
Bug 830451
Opened 11 years ago
Closed 11 years ago
ICE stack should ignore rather than assert on PEER_REFLEXIVE
Categories
(Core :: WebRTC: Networking, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: ehugg, Assigned: ehugg)
Details
(Whiteboard: [webrtc][blocking-webrtc+][nICEr][nICEr-upstream-needed][qa-])
Attachments
(1 file)
1.32 KB,
patch
|
abr
:
review+
|
Details | Diff | Splinter Review |
PEER_REFLEXIVE should be treated the same as SERVER_REFLEXIVE, currently we throw an ASSERT.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #701915 -
Flags: review?(ekr)
Comment 2•11 years ago
|
||
Comment on attachment 701915 [details] [diff] [review] Treat PEER_REFLEXIVE like SERVER_REFLEXIVE Review of attachment 701915 [details] [diff] [review]: ----------------------------------------------------------------- Since I suggested this change, let's let abr review it
Attachment #701915 -
Flags: review?(ekr) → review?(adam)
Updated•11 years ago
|
Assignee: nobody → ethanhugg
Priority: -- → P2
Whiteboard: [webrtc][blocking-webrtc+]
Comment 3•11 years ago
|
||
Comment on attachment 701915 [details] [diff] [review] Treat PEER_REFLEXIVE like SERVER_REFLEXIVE Review of attachment 701915 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me. Sorry for taking so long to review it -- it took me a while to convince myself that this is correct per spec. The relevant text is in RFC 5245, section 7.1.3.2.1: "the peer reflexive candidate is not paired with other remote candidates."
Attachment #701915 -
Flags: review?(adam) → review+
Updated•11 years ago
|
Whiteboard: [webrtc][blocking-webrtc+] → [webrtc][blocking-webrtc+][nICEr]
Updated•11 years ago
|
Whiteboard: [webrtc][blocking-webrtc+][nICEr] → [webrtc][blocking-webrtc+][nICEr][nICEr-upstream-needed]
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c71380f318ed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c71380f318ed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Updated•11 years ago
|
Whiteboard: [webrtc][blocking-webrtc+][nICEr][nICEr-upstream-needed] → [webrtc][blocking-webrtc+][nICEr][nICEr-upstream-needed][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•