Closed
Bug 830451
Opened 13 years ago
Closed 13 years ago
ICE stack should ignore rather than assert on PEER_REFLEXIVE
Categories
(Core :: WebRTC: Networking, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: ehugg, Assigned: ehugg)
Details
(Whiteboard: [webrtc][blocking-webrtc+][nICEr][nICEr-upstream-needed][qa-])
Attachments
(1 file)
|
1.32 KB,
patch
|
abr
:
review+
|
Details | Diff | Splinter Review |
PEER_REFLEXIVE should be treated the same as SERVER_REFLEXIVE, currently we throw an ASSERT.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #701915 -
Flags: review?(ekr)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 701915 [details] [diff] [review]
Treat PEER_REFLEXIVE like SERVER_REFLEXIVE
Review of attachment 701915 [details] [diff] [review]:
-----------------------------------------------------------------
Since I suggested this change, let's let abr review it
Attachment #701915 -
Flags: review?(ekr) → review?(adam)
|
||
Updated•13 years ago
|
Assignee: nobody → ethanhugg
Priority: -- → P2
Whiteboard: [webrtc][blocking-webrtc+]
|
||
Comment 3•13 years ago
|
||
Comment on attachment 701915 [details] [diff] [review]
Treat PEER_REFLEXIVE like SERVER_REFLEXIVE
Review of attachment 701915 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good to me. Sorry for taking so long to review it -- it took me a while to convince myself that this is correct per spec. The relevant text is in RFC 5245, section 7.1.3.2.1: "the peer reflexive candidate is not paired with other remote candidates."
Attachment #701915 -
Flags: review?(adam) → review+
|
|
||
Updated•13 years ago
|
Whiteboard: [webrtc][blocking-webrtc+] → [webrtc][blocking-webrtc+][nICEr]
|
|
||
Updated•13 years ago
|
Whiteboard: [webrtc][blocking-webrtc+][nICEr] → [webrtc][blocking-webrtc+][nICEr][nICEr-upstream-needed]
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
|
||
Updated•13 years ago
|
Whiteboard: [webrtc][blocking-webrtc+][nICEr][nICEr-upstream-needed] → [webrtc][blocking-webrtc+][nICEr][nICEr-upstream-needed][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•