Closed Bug 830458 Opened 7 years ago Closed 7 years ago

ConfigStatus.py needs to import errno

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: mmc, Assigned: mmc)

Details

Attachments

(1 file, 2 obsolete files)

import errno fixes this error

2:14.44 /home/mchew/clean/mozilla-central/config/rules.mk:1144: target `security/build/Makefile' given more than once in the same rule.
 2:14.57 creating ../../../../../db/sqlite3/src/Makefile
 2:14.59 Traceback (most recent call last):
 2:14.59   File "./config.status", line 1970, in <module>
 2:14.59     config_status(**args)
 2:14.59   File "/home/mchew/clean/mozilla-central/build/ConfigStatus.py", line 328, in config_status
 2:14.59     env.create_config_file(file)
 2:14.59   File "/home/mchew/clean/mozilla-central/build/ConfigStatus.py", line 207, in create_config_file
 2:14.59     pp.do_include(input)
 2:14.59   File "/home/mchew/clean/mozilla-central/build/ConfigStatus.py", line 90, in __exit__
 2:14.59     self.close()
 2:14.59   File "/home/mchew/clean/mozilla-central/build/ConfigStatus.py", line 83, in close
 2:14.59     ensureParentDir(self.filename)
 2:14.59   File "/home/mchew/clean/mozilla-central/build/ConfigStatus.py", line 54, in ensureParentDir
 2:14.59     if error.errno != errno.EEXIST:
 2:14.59 NameError: global name 'errno' is not defined
 2:14.63 make[5]: *** [/db/sqlite3/src/Makefile] Error 1
 2:14.63 make[4]: *** [export_tier_platform] Error 2
Assignee: nobody → gps
Attached patch Import errno in ConfigStatus.py (obsolete) — Splinter Review
Assignee: gps → mmc
Status: NEW → ASSIGNED
Attachment #701966 - Flags: review?(gps)
Attached patch Import errno in ConfigStatus.py (obsolete) — Splinter Review
Attachment #701966 - Attachment is obsolete: true
Attachment #701966 - Flags: review?(gps)
Attachment #701971 - Flags: review?(gps)
Comment on attachment 701971 [details] [diff] [review]
Import errno in ConfigStatus.py

Review of attachment 701971 [details] [diff] [review]:
-----------------------------------------------------------------

Please add a bug number to the commit message.
Attachment #701971 - Flags: review?(gps) → review+
Fix patch description to include bug number and r=gps
Attachment #701971 - Attachment is obsolete: true
Attachment #701986 - Attachment is patch: true
I always forget about that file mirroring! Thanks for fixing it, Ehsan.
Is there a way to just link a softcopy to the js build? I did not know about file mirroring at all.
(In reply to Monica Chew from comment #8)
> Is there a way to just link a softcopy to the js build? I did not know about
> file mirroring at all.

Not really. I hope to get rid of the copied files sometime in 2013. It's not too much work - someone just needs to code up the build system integration.
(In reply to comment #8)
> Is there a way to just link a softcopy to the js build? I did not know about
> file mirroring at all.

FWIW, if you build locally with |./mach build|, you'll see build failures locally when you don't mirror files probably (and don't feel too bad about it -- everybody forgets!).
https://hg.mozilla.org/mozilla-central/rev/aa336551620e
https://hg.mozilla.org/mozilla-central/rev/a6e90d2ea967
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.