830458 - ConfigStatus.py needs to import errno

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

import errno fixes this error

2:14.44 /home/mchew/clean/mozilla-central/config/rules.mk:1144: target `security/build/Makefile' given more than once in the same rule.
 2:14.57 creating ../../../../../db/sqlite3/src/Makefile
 2:14.59 Traceback (most recent call last):
 2:14.59   File "./config.status", line 1970, in <module>
 2:14.59     config_status(**args)
 2:14.59   File "/home/mchew/clean/mozilla-central/build/ConfigStatus.py", line 328, in config_status
 2:14.59     env.create_config_file(file)
 2:14.59   File "/home/mchew/clean/mozilla-central/build/ConfigStatus.py", line 207, in create_config_file
 2:14.59     pp.do_include(input)
 2:14.59   File "/home/mchew/clean/mozilla-central/build/ConfigStatus.py", line 90, in __exit__
 2:14.59     self.close()
 2:14.59   File "/home/mchew/clean/mozilla-central/build/ConfigStatus.py", line 83, in close
 2:14.59     ensureParentDir(self.filename)
 2:14.59   File "/home/mchew/clean/mozilla-central/build/ConfigStatus.py", line 54, in ensureParentDir
 2:14.59     if error.errno != errno.EEXIST:
 2:14.59 NameError: global name 'errno' is not defined
 2:14.63 make[5]: *** [/db/sqlite3/src/Makefile] Error 1
 2:14.63 make[4]: *** [export_tier_platform] Error 2

Comment 1

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: Import errno in ConfigStatus.py

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: Import errno in ConfigStatus.py

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 701971 [details] [diff] [review]
Import errno in ConfigStatus.py

Review of attachment 701971 [details] [diff] [review]:
-----------------------------------------------------------------

Please add a bug number to the commit message.

Comment 4

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: Import errno in ConfigStatus.py (bug=830458, r=gps)

Fix patch description to include bug number and r=gps

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa336551620e

Comment 6

[(no longer active)]

This broke builds, and I fixed it: https://hg.mozilla.org/integration/mozilla-inbound/rev/a6e90d2ea967

Comment 7

[Gregory Szorc [:gps]]

I always forget about that file mirroring! Thanks for fixing it, Ehsan.

Comment 8

[[:mmc] Monica Chew (no longer reading bugmail)]

Is there a way to just link a softcopy to the js build? I did not know about file mirroring at all.

Comment 9

[Gregory Szorc [:gps]]

(In reply to Monica Chew from comment #8)
> Is there a way to just link a softcopy to the js build? I did not know about
> file mirroring at all.

Not really. I hope to get rid of the copied files sometime in 2013. It's not too much work - someone just needs to code up the build system integration.

Comment 10

[(no longer active)]

(In reply to comment #8)
> Is there a way to just link a softcopy to the js build? I did not know about
> file mirroring at all.

FWIW, if you build locally with |./mach build|, you'll see build failures locally when you don't mirror files probably (and don't feel too bad about it -- everybody forgets!).

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aa336551620e
https://hg.mozilla.org/mozilla-central/rev/a6e90d2ea967