830472 - Firefox should fail more gracefully when it fails to build w/ VS2012 w/o Update 1

Status: NEW

(Firefox Build System :: General, defect)

Description

[(no longer active)]

Attachment: Build log

Please see the log.  Looks like we're mixing debug and release runtime libs?  I'm using VS2012 if that matters.

Comment 1

[(no longer active)]

Here's my mozconfig:

$ cat .mozconfig-opt
mk_add_options MOZ_MAKE_FLAGS="-s -j36"
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-ff-opt
ac_add_options --disable-debug
ac_add_options --enable-optimize
ac_add_options --enable-dmd

Comment 2

[(no longer active)]

I took out --enable-dmd and it didn't help.  Updating VS2012 next.

Comment 3

[(no longer active)]

Hmm, updating VS did the trick.  Brian, can we perhaps detect the old compiler version and error out in configure.in or something with a good message asking the user to upgrade?

Comment 4

[Brian R. Bondy [:bbondy]]

Yup

Comment 5

[Brian R. Bondy [:bbondy]]

I'll assign myself in case someone can get to it faster.

Comment 6

[Jim Mathies [:jimm]]

I'm not sure if this is a valid bug. I can build rel opt with both vs10 and vs11.

Comment 7

[(no longer active)]

(In reply to comment #6)
> I'm not sure if this is a valid bug. I can build rel opt with both vs10 and
> vs11.

With VS11 without the update?

Comment 8

[Gregory Szorc [:gps]]

Sounds like configure should abort if we try compiling on VS2012 without Update 1 or newer?

Comment 9

[Brian R. Bondy [:bbondy]]

Yup I think so, as per Comment 3

Comment 10

[Jim Mathies [:jimm]]

(In reply to :Ehsan Akhgari from comment #7)
> (In reply to comment #6)
> > I'm not sure if this is a valid bug. I can build rel opt with both vs10 and
> > vs11.
> 
> With VS11 without the update?

Ah no, 11.0.51106.01 Update 1. Strange though as I never had this problem before the update either.

Comment 11

[Jim Mathies [:jimm]]

Were you still on the preview release perhaps?

Comment 12

[(no longer active)]

(In reply to comment #11)
> Were you still on the preview release perhaps?

No, this was a recent problem caused by something that landed recently I assume.