830527 - [Cost Control] Dates in Cost Control application are not localizable

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Staś Małolepszy :stas]

Attachment: Screenshot

The chart in the cost control app has uses dates to annotate the horizontal axis.  The format is not localizable.  See attached screenshot.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Stealing :)

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to GitHub PR 7665

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 703283 [details]
Pointer to GitHub PR 7665

Adding Kaze as reviewer as he has some input for this patch

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

New version on github with comments from Kaze added.

Salva we modified the format to '%b %e' to avoid dates like 'FEB 01', if that was on purpose, please let me know and will amend the commit.

Thanks folks!

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 703283 [details]
Pointer to GitHub PR 7665

Stealing review from stas.

Can you make the comment on the dateformat include a link to http://pubs.opengroup.org/onlinepubs/007908799/xsh/strftime.html ? Then localizers don't need to remember that link from elsewhere.

I didn't dive into the details of the flow, is the l10n data loaded for sure when that code is triggered?

Also, the upperCase is concerning me. Do we *really* want that? We just removed the text transform elsewhere, but didn't dive into js ways of doing the same thing.

Clearing the review request, this isn't much of an r- or r+, but a few things for the fellow reviewers to take into account.

Comment 6

[Salvador de la Puente González [:salva]]

Rewording to clarify the nature of the bug and solve it once for all.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 703283 [details]
Pointer to GitHub PR 7665

Axel, I'm asking you again for review cause we modified the scope, not just a single piece, but all the missing l10n for cost control.

Thanks

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 703283 [details]
Pointer to GitHub PR 7665

I think from an l10n pov this looks OK, relying on the other reviewers for the actual code pieces.

Comment 9

[Fabien Cazenave [:kaze]]

Comment on attachment 703283 [details]
Pointer to GitHub PR 7665

The `short-date-format' l10n entity doesn’t look right, see my comments on github. Feel free to r? me when your PR is updated.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 703283 [details]
Pointer to GitHub PR 7665

PR updated with requested changes.

Thanks guys!

Comment 11

[Salvador de la Puente González [:salva]]

Attachment: Removing NO-SIM scenario due to lack of madurity

Comment 12

[Salvador de la Puente González [:salva]]

Comment on attachment 703831 [details]
Removing NO-SIM scenario due to lack of madurity

It has been necessary to bump some l10n strings. As they are used dynamically on code, this code has been modified as well.

Comment 13

[Axel Hecht [:Pike]]

(In reply to Salvador de la Puente González [:salva] from comment #12)
> Comment on attachment 703831 [details]
> Removing NO-SIM scenario due to lack of madurity
> 
> It has been necessary to bump some l10n strings. As they are used
> dynamically on code, this code has been modified as well.

salva, attach that PR over in bug 831274?

Comment 14

[Salvador de la Puente González [:salva]]

Comment on attachment 703831 [details]
Removing NO-SIM scenario due to lack of madurity

Please, can someone delete this attachment. It is missplaced.

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 703831 [details]
Removing NO-SIM scenario due to lack of madurity

Not a real patch for this bug, just a tragic error ;)

Comment 16

[Fabien Cazenave [:kaze]]

Comment on attachment 703283 [details]
Pointer to GitHub PR 7665

Thanks for the fixes! :-)

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/891a7e8d3fc21bcd4a3a2995b24a52b73d1a6e62

Comment 18

[Walter Chen[:ypwalter][:wachen]]

Verified fixed in pvt b2g18 user build.

Gaia:
  Rev     7cacbcb8042b49d816a34de8e9767dcedefa6d84
  B-D     2013-01-25 02:57:10
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/32c2cc3e19ff
BuildID   20130124140859
Version   18.0

The format of data in different lang looks like a different lang for me.

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.