Closed
Bug 830540
Opened 12 years ago
Closed 12 years ago
Update about:privatebrowsing mask image
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox20 verified, firefox21 verified)
VERIFIED
FIXED
Firefox 21
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file)
|
44.34 KB,
patch
|
mfinkle
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We need to update the mask image to remove the dark ring that appears from the gradient.
Attachment #702047 -
Flags: review?(mark.finkle)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 702047 [details] [diff] [review]
Update about:privatebrowsing mask image
It still irks me that is image is so big
Attachment #702047 -
Flags: review?(mark.finkle) → review+
|
||
Comment 2•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #1)
> Comment on attachment 702047 [details] [diff] [review]
> Update about:privatebrowsing mask image
>
> It still irks me that is image is so big
Perhaps we can run pngcrush on it?
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to :Ehsan Akhgari from comment #2)
> (In reply to Mark Finkle (:mfinkle) from comment #1)
> > Comment on attachment 702047 [details] [diff] [review]
> > Update about:privatebrowsing mask image
> >
> > It still irks me that is image is so big
>
> Perhaps we can run pngcrush on it?
I just tried pngcrush, but it only reduced the image by 1kB.
|
|
Assignee | |
Comment 4•12 years ago
|
||
status-firefox20:
--- → affected
|
|
Assignee | |
Comment 5•12 years ago
|
||
Comment on attachment 702047 [details] [diff] [review]
Update about:privatebrowsing mask image
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 818065
User impact if declined: mask image has a dark ring around it in about:privatebrowsing
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): very low
String or UUID changes made by this patch: none
Attachment #702047 -
Flags: approval-mozilla-aurora?
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
|
||
Comment 7•12 years ago
|
||
Comment on attachment 702047 [details] [diff] [review]
Update about:privatebrowsing mask image
low risk for a new feature in aurora.Approving
Attachment #702047 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Updated•12 years ago
|
status-firefox21:
--- → fixed
|
||
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
|
|
Assignee | |
Comment 8•12 years ago
|
||
|
||
Comment 9•12 years ago
|
||
Verified on Firefox Mobile 20 beta 5 on the Samsung Galaxy Tab 2 7.0 (Android 4.1.1)
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•