Closed Bug 830540 Opened 11 years ago Closed 11 years ago

Update about:privatebrowsing mask image

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox20 verified, firefox21 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 21
Tracking Flags:
Tracking Status
firefox20 --- verified
firefox21 --- verified

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

Update about:privatebrowsing mask image
44.34 KB, patch
mfinkle
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
We need to update the mask image to remove the dark ring that appears from the gradient.
Attachment #702047 - Flags: review?(mark.finkle)
Blocks: 818065
Comment on attachment 702047 [details] [diff] [review]
Update about:privatebrowsing mask image

It still irks me that is image is so big
Attachment #702047 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #1)
> Comment on attachment 702047 [details] [diff] [review]
> Update about:privatebrowsing mask image
> 
> It still irks me that is image is so big

Perhaps we can run pngcrush on it?
(In reply to :Ehsan Akhgari from comment #2)
> (In reply to Mark Finkle (:mfinkle) from comment #1)
> > Comment on attachment 702047 [details] [diff] [review]
> > Update about:privatebrowsing mask image
> > 
> > It still irks me that is image is so big
> 
> Perhaps we can run pngcrush on it?

I just tried pngcrush, but it only reduced the image by 1kB.
Comment on attachment 702047 [details] [diff] [review]
Update about:privatebrowsing mask image

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 818065
User impact if declined: mask image has a dark ring around it in about:privatebrowsing
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): very low
String or UUID changes made by this patch: none
Attachment #702047 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/f2d965c21656
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Comment on attachment 702047 [details] [diff] [review]
Update about:privatebrowsing mask image

low risk for a new feature in aurora.Approving
Attachment #702047 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: RESOLVED → VERIFIED
status-firefox21: fixed → verified
Verified on Firefox Mobile 20 beta 5 on the Samsung Galaxy Tab 2 7.0 (Android 4.1.1)
status-firefox20: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: