830549 - GCC 4.6 build warning: "nsFind.cpp:1205:18: warning: variable 'rv' set but not used [-Wunused-but-set-variable]"

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Daniel Holbert [:dholbert]]

Ran across this build warning when doing a try run w/ embedding/components/find/src marked as FAIL_ON_WARNINGS:
{
nsFind.cpp:1205:18: warning: variable 'rv' set but not used [-Wunused-but-set-variable]
}

(though it was actually reported as an error in my build log, because I'd speculatively added FAIL_ON_WARNINGS:
https://tbpl.mozilla.org/php/getParsedLog.php?id=18789569&tree=Try#error0 )

This code dates back to bug 132612, and the variable just wants to be marked as DebugOnly.  Patch coming up to do that.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[[e-mail]]

Comment on attachment 702064 [details] [diff] [review]
fix

(Hopefully this will get converted to use nsIContent throughout at some point.)

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4388665988c

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c4388665988c