Closed
Bug 830549
Opened 11 years ago
Closed 11 years ago
GCC 4.6 build warning: "nsFind.cpp:1205:18: warning: variable 'rv' set but not used [-Wunused-but-set-variable]"
Categories
(Core Graveyard :: Embedding: APIs, defect)
Core Graveyard
Embedding: APIs
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.69 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Ran across this build warning when doing a try run w/ embedding/components/find/src marked as FAIL_ON_WARNINGS: { nsFind.cpp:1205:18: warning: variable 'rv' set but not used [-Wunused-but-set-variable] } (though it was actually reported as an error in my build log, because I'd speculatively added FAIL_ON_WARNINGS: https://tbpl.mozilla.org/php/getParsedLog.php?id=18789569&tree=Try#error0 ) This code dates back to bug 132612, and the variable just wants to be marked as DebugOnly. Patch coming up to do that.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #702064 -
Flags: review?(neil)
Assignee | ||
Updated•11 years ago
|
Blocks: buildwarning, 132612
Comment 2•11 years ago
|
||
Comment on attachment 702064 [details] [diff] [review] fix (Hopefully this will get converted to use nsIContent throughout at some point.)
Attachment #702064 -
Flags: review?(neil) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4388665988c
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c4388665988c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•