830550 - Show header error style on all PIN pages

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[Kumar McMillan [:kumar]]

This is an extension of prettification in bug 806419. All PIN templates should act like the verify-PIN template.

We have an includable template https://github.com/mozilla/webpay/blob/master/webpay/pin/templates/pin/includes/verify_form.html

but this is not used by pin/confirm.html, pin/create.html, pin/reset_confirm.html, or pin/reset_create.html

Comment 1

[Potch [:potch]]

I can do this if need be- I'm a template jockey! I was considering generalizing this include into simply a "pin_form.html" which seems to mesh well with this.

Comment 2

[Potch [:potch]]

presently blocked on this due to identity being busted on b2g desktop.

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Potch [:potch] from comment #2)
> presently blocked on this due to identity being busted on b2g desktop.

There was an identity outage around 1.30 to 2.30 Pacific time today, but that has been resolved.  Bug 830998

Are you still unable to connect?

Comment 4

[Potch [:potch]]

oh sorry! I'm all unblocked. Thanks.

Comment 5

[Potch [:potch]]

https://github.com/mozilla/webpay/commit/52e10d4

Comment 6

[krupa raj[:krupa]]

We have newer design styles now and all error messages are relatively pretty.