830612 - Fix UP_watchdogTimerFired to use notify instead

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Dave Hylands [:dhylands]]

This is a followup bug from bug 825598 comment 42 to integrate UP_watchdogTimerFired into the existing timer notify function.

Comment 1

[Dave Hylands [:dhylands]]

Attachment: Use existing notify function rather than providing an explicit callback.

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 790959 [details] [diff] [review]
Use existing notify function rather than providing an explicit callback.

I know you've reviewed update stuff on the gaia side of things, so I thought I'd throw this one your way. Let me know if I should reassign. Thanks

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 790959 [details] [diff] [review]
Use existing notify function rather than providing an explicit callback.

Review of attachment 790959 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit, because this is simple enough for me to understand ;)

::: b2g/components/UpdatePrompt.js
@@ +531,4 @@
>    _startedSent: false,
>  
>    _watchdogTimer: null,
>    _watchdogTimeout: 0,

if you make it local to the function, don't forget to remove it from here too (see below)

@@ +540,5 @@
>      if (this._watchdogTimer) {
>        this._watchdogTimer.cancel();
>      } else {
>        this._watchdogTimer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer);
>        this._watchdogTimeout = Services.prefs.getIntPref(PREF_DOWNLOAD_WATCHDOG_TIMEOUT);

do we really need to put _watchdogTimeout as a instance variable ? I'd say this could stay local to this function instead.

Comment 4

[Dave Hylands [:dhylands]]

 https://hg.mozilla.org/integration/b2g-inbound/rev/679c72ad37d7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/679c72ad37d7