Closed
Bug 830618
Opened 8 years ago
Closed 8 years ago
Defect - Give site authors the ability to link Windows store apps w/ their page for IE10 parity
Categories
(Firefox for Metro Graveyard :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: bbondy, Assigned: kjozwiak)
References
Details
(Whiteboard: feature=defect c=tbd u=tbd p=0)
Attachments
(3 files, 3 obsolete files)
9.05 KB,
image/jpeg
|
Details | |
10.37 KB,
image/png
|
ywang
:
ui-review+
|
Details |
4.23 KB,
patch
|
kjozwiak
:
review+
|
Details | Diff | Splinter Review |
IE10 can link HTML5 app w/ a page, "Get app for this site". This would probably add a menu item to one of the appbar icons. <meta name="msApplication-ID" content="App"/> <meta name="msApplication-PackageFamilyName" content="ZeptoLabUKLimited.CutTheRope_sq9zxnwrk84pj"/>
![]() |
||
Updated•8 years ago
|
Whiteboard: [preview-triage]
Reporter | ||
Comment 1•8 years ago
|
||
There is text needed for the menu "Get app for this site" so if we want this later it can't be uplifted past mozilla-central. Attached a screenshot of how it looks in IE.
Reporter | ||
Comment 2•8 years ago
|
||
kjozwiak this is probably a good bug for you if you're interested. I think we'd just show/hide the menu item depending on if the site has meta tags in it. See the attachment image in Comment 1. You'd check for these meta tags "msApplication-ID", and "msApplication-PackageFamilyName" which look like this in the head of the current page: <meta name="msApplication-ID" content="microsoft.build.App" /> <meta name="msApplication-PackageFamilyName" content="microsoft.build_8wekyb3d8bbwe"/> And if they exist, then you'd selectively show/hide the menu item in the appbar settings icon. If the menu is clicked you'd open the link, something like this: location.href = "ms-windows-store:PDP?PFN=microsoft.build_8wekyb3d8bbwe"
Assignee | ||
Comment 3•8 years ago
|
||
Sounds good, thanks Brian! Appreciate it. I will start this one when I am finished with Bug 885383 which should be completed by this week.
Assignee: nobody → kamiljoz
Updated•8 years ago
|
Blocks: metrov1backlog
Summary: Give site authors the ability to link Windows store apps w/ their page for IE10 parity → Defect - Give site authors the ability to link Windows store apps w/ their page for IE10 parity
Whiteboard: [preview-triage] → [preview-triage] feature=defect c=tbd u=tbd p=0
Updated•8 years ago
|
![]() |
||
Comment 4•8 years ago
|
||
We'd really really like a patch, but won't block on this. :)
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=0
Assignee | ||
Comment 5•8 years ago
|
||
work in progress: code to detect meta tags
Assignee | ||
Comment 6•8 years ago
|
||
Attached current WIP
Assignee | ||
Comment 7•8 years ago
|
||
Went through testing and everything seems like its working: - Ensured that the menu item doesn't appear when the meta data isn't found (tried several popular websites) - Ensured that the menu item appeared correctly when the appropriate meta data was found - Ensured that clicking on the menu item took the user to the MS store and displayed the correct application - Ensured that the other menu items still worked without any issues You can use this page that I created for testing: https://s3.amazonaws.com/coding/METAdisabled.html
Attachment #802086 -
Attachment is obsolete: true
Attachment #808771 -
Attachment is obsolete: true
Attachment #810336 -
Flags: review?(jmathies)
Assignee | ||
Comment 8•8 years ago
|
||
Forgot to add the page that has META data, this will open the "Cut the Rope" game in the MS store: https://s3.amazonaws.com/coding/METAenabled.html
Assignee | ||
Comment 9•8 years ago
|
||
Yuan, please let me know if you would like this changed. Used the same label as the original screenshot Brian added.
Attachment #810340 -
Flags: ui-review?(ywang)
![]() |
||
Comment 10•8 years ago
|
||
Comment on attachment 810336 [details] [diff] [review] Checking meta data then adds appropriate menu entry that takes user to MS store Review of attachment 810336 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/metro/base/content/ContextCommands.js @@ +265,5 @@ > + Browser.selectedBrowser.contentWindow.document.location = storeLink; > + } > + }, > + > + getStoreLink: function cc_getStoreLink() { you might want to add a comment header here explaining what this is about. ::: browser/metro/locales/en-US/chrome/browser.dtd @@ +16,5 @@ > <!ENTITY appbarErrorConsole.label "Open error console"> > <!ENTITY appbarJSShell.label "Open JavaScript shell"> > <!ENTITY appbarFindInPage2.label "Find in page"> > <!ENTITY appbarViewOnDesktop2.label "View on desktop"> > +<!ENTITY appbarMSMetaData2.label "Get app for this site"> nit - line up
Attachment #810336 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 11•8 years ago
|
||
Jim, could you push to the try server?
Attachment #810336 -
Attachment is obsolete: true
Attachment #811148 -
Flags: review+
![]() |
||
Comment 12•8 years ago
|
||
sure - https://tbpl.mozilla.org/?tree=Try&rev=e4f7dc4299b6
Updated•8 years ago
|
Attachment #810340 -
Flags: ui-review?(ywang) → ui-review+
Comment 14•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ae03c0e61c14
Keywords: checkin-needed
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=0[fixed-in-fx-team]
Updated•8 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
https://hg.mozilla.org/mozilla-central/rev/ae03c0e61c14
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: feature=defect c=tbd u=tbd p=0[fixed-in-fx-team] → feature=defect c=tbd u=tbd p=0
Target Milestone: --- → Firefox 27
Updated•7 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•