Closed Bug 830659 Opened 11 years ago Closed 11 years ago

The apps permissions UI does not list the system and homescreen apps, even though they call out support for geolocation

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 fixed)

VERIFIED FIXED
blocking-b2g tef+
Tracking Status
b2g18 --- fixed
b2g18-v1.0.0 --- fixed

People

(Reporter: jsmith, Assigned: ochameau)

References

Details

(Whiteboard: [triaged:1/15])

Attachments

(1 file)

The apps permissions UI in the settings currently does not list the system app or homescreen app in the list of available apps to modify permissions for. This isn't correct - any certified app that calls out support for geolocation should be listed in that UI.

This is particularly important for the case of everything.me in the homescreen, which makes requests for geolocation in the homescreen. So the footgun of lack of perms management control exists here for the homescreen with everything.me's use of geolocation. Don't know too much of the impact on the system app.
Blocks: 828214
blocking-b2g: --- → tef?
tracking-b2g18: --- → ?
Note that currently those apps are explicitly hidden (ie. we have a list of hidden apps).

So while displaying them is just a config change it might be good to check why they were hidden in the first place.
blocking-b2g: tef? → -
Whiteboard: [EU_TPE_TRIAGED]
Uhh....triage drivers are wrong here. This was made a requirement in a separate bug for certified apps. And we know everything.me is doing something "weird" here, which was the whole reason this was introduced.

I literally do not understand why Gaia triage drivers do not understand how this feature set works. Someone has had to triage this multiple times because it's not understood what the impact is.
blocking-b2g: - → tef?
Whiteboard: [EU_TPE_TRIAGED]
I'm just going to ask Jonas to triage this. He knows has this feature works. Sigh...
Flags: needinfo?(jonas)
blocking-b2g: tef? → tef+
Flags: needinfo?(jonas)
Whiteboard: [triaged:1/15]
Assignee: nobody → poirot.alex
Attached file Pull request 7652
Attachment #702898 - Flags: review?(21)
tracking-b2g18: + → ---
https://github.com/mozilla-b2g/gaia/commit/f2a0ed60c5cddacb51131763ec50d2e80b9270d6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Keywords: verifyme
QA Contact: jsmith
Was it intentional to show the system app in the permissions UI? I think it might be confusing for users what it means to turn off geolocation for the system app.

The effect it will have is that none of the homescreen bookmarks or everything.me apps will have the ability to use geolocation. Was that intended?
(In reply to Jonas Sicking (:sicking) from comment #6)
> Was it intentional to show the system app in the permissions UI? I think it
> might be confusing for users what it means to turn off geolocation for the
> system app.
> 
> The effect it will have is that none of the homescreen bookmarks or
> everything.me apps will have the ability to use geolocation. Was that
> intended?

Originally, yes because of the fact that the system app was a certified app which called out support for geolocation in the permissions property.

I guess this implementation went with a "catch all" approach then - if it has geolocation in the permissions property, then we show it in the apps perm UI.
Verified on 1/18. I'm seeing both apps getting listed.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: