Open Bug 830675 Opened 8 years ago Updated 7 years ago

Sometimes the same downloaded file may show different sizes in the library

Categories

(Firefox :: Downloads Panel, defect)

defect
Not set
normal

Tracking

()

People

(Reporter: simona.marcu, Unassigned)

References

Details

(Keywords: helpwanted)

Attachments

(2 files)

Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20130114 Firefox/21.0
Build ID: 20130114031033

Steps to reproduce:
1. Launch Firefox and navigate to: 
http://www.mozilla.org/en-US/mission/
2. Save the page: File menu -> Save Page As...
3. After the download is complete, open the library and the panel and observe the size.

Expected results:
The page is saved and the displayed size in the panel and in the library view is the same.

Actual results:
The displayed size in the panel is different from the size displayed in the library view.
Summary: The size in the panel and the library view is different → The size in the panel is different from the one in the library
Attached image Screenshot
to be investigated
that the panel just uses maxBytes reported by the download manager, while the Library also checks the file size on disk.
When saving complete web pages thus the panel shows the size of all the files that were downloaded, while the Library just shows the size of the html file.
Summary: The size in the panel is different from the one in the library → The size in the panel is different from the one in the library when saving complete web pages
(In reply to Marco Bonardo [:mak] from comment #3)
> that the panel just uses maxBytes reported by the download manager, while
> the Library also checks the file size on disk.
> When saving complete web pages thus the panel shows the size of all the
> files that were downloaded, while the Library just shows the size of the
> html file.

In the Library, the size of the html file also differs even if I make the same download several times (please see the screenshot). If I close the Library  window and I open it again, the size is the same for all the entries.
Summary: The size in the panel is different from the one in the library when saving complete web pages → The size in the panel is different from the one in the library
Summary: The size in the panel is different from the one in the library → The size in the panel is different from the one in the library when saving complete web pages
bug 826991 fixed part of this bug, the Library will use the same size as the panel
Assignee: mano → nobody
Depends on: 826991
the most confusing part of the bug (panel showing one size, library showing another one) should be fixed, leaving this open to evaluate comment 5, but not blocking anymore. While annoying, the slightly different sizes are a minor issue and not affecting functionality.
No longer blocks: ReleaseDownloadsPane
ah sorry, I wrongly unassigned this.
Assignee: nobody → mano
Actually, given the scope of the remaining issue, off-loading this for now.
Assignee: mano → nobody
Keywords: helpwanted
Summary: The size in the panel is different from the one in the library when saving complete web pages → Sometimes the same downloaded file may show different sizes in the library
The issue in comment 5 might be related to the fact that the currentBytes property (that may be used by maxBytes for downloads with no progress indication) may not always be updated with the latest value when the download finishes.

The library is supposed to read the file size from disk, but _fetchTargetFileInfo is called asynchronously and it only updates the size variables, and those may not be picked up in the metadata object in time for being displayed.

The work in bug 1116176 can fix this.
Depends on: 1116176
(In reply to :Paolo Amadini from comment #10)
> The library is supposed to read the file size from disk, but
> _fetchTargetFileInfo is called asynchronously and it only updates the size
> variables, and those may not be picked up in the metadata object in time for
> being displayed.
> 
> The work in bug 1116176 can fix this.

Hm, on second thought, we should probably look into resolving the size issue when the Places metadata is written by the DownloadsCommon view. Bug 941063 will help by providing a reliable property with the file size. The Places view should trust the metadata and not do any additional I/O.
Depends on: 941063
No longer depends on: 1116176
You need to log in before you can comment on or make changes to this bug.