Closed
Bug 830724
Opened 13 years ago
Closed 13 years ago
Make manifests localizable for Keyboard and Wallpaper
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g18 fixed, b2g18-v1.0.1 fixed)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: stas)
Details
(Keywords: l12y)
Attachments
(1 file)
|
839 bytes,
patch
|
kaze
:
review+
vingtetun
:
approval-gaia-v1+
|
Details | Diff | Splinter Review |
Filing one bug for both apps as this is a small change.
The manifest files for Keyboard and Wallpaper should be localizable.
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Comment 2•13 years ago
|
||
Comment on attachment 702269 [details] [diff] [review]
Patch
LGTM + requesting approval to land this with 1.0 if it’s still time to.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): ?
User impact if declined: low (wallpaper / keyboard app names won't be localized)
Testing completed: manual
Risk to taking this patch (and alternatives if risky): very low
Attachment #702269 -
Flags: review?(kaze)
Attachment #702269 -
Flags: review+
Attachment #702269 -
Flags: approval-gaia-master?(21)
Attachment #702269 -
Flags: approval-gaia-master?(21) → approval-gaia-master+
|
|
Assignee | |
Comment 3•13 years ago
|
||
I landed commit https://github.com/mozilla-b2g/gaia/commit/7c3a180c6b29434c822fcd83e803a30a9e0a7a73 on master: The merge commit is: https://github.com/mozilla-b2g/gaia/commit/e6a30b915660e701fe635104dceffdd162b9de4f
|
||
Comment 4•13 years ago
|
||
Batch edit: Bugs fixed on b2g18 after 1/25 merge to v1.0 branch are fixed on v1.0.1 branch.
status-b2g18-v1.0.1:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•