830785 - NSS is built with OS_TARGET=WIN95

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

We have this in security/build/Makefile.in:
  DEFAULT_GMAKE_FLAGS += OS_TARGET=WIN95

AFAICT, it doesn't make much difference from OS_TARGET=WINNT: a few things change in the mutex implementation, -GT is added to CFLAGS and library names are prefixed with "lib" (NSPR31_LIB_PREFIX = lib in security/coreconf/WINNT.mk)

Somehow I feel we should switch to OS_TARGET=WINNT.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Don't build NSS with OS_TARGET=WIN95 when OS_ARCH=WINNT

https://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Don't we use OS_TARGET=WIN95 for NSPR?  We should probably keep those in sync.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #2)
> Don't we use OS_TARGET=WIN95 for NSPR?  We should probably keep those in
> sync.

Looks like we do, but i don't know where it's set. We should probably change that. I guess that's inherited from the time we still supported win9x.

Comment 4

[Mike Hommey [:glandium]]

Found it:
http://hg.mozilla.org/mozilla-central/file/77e4b2a4cc31/nsprpub/configure.in#l960

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

My understanding is that there are significant differences between WIN95 and WINNT NSPR and that we shouldn't switch that lightly.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Don't build NSPR with OS_TARGET=WIN95 when OS_ARCH=WINNT

Comment 7

[Mike Hommey [:glandium]]

Attachment: Don't build NSPR with OS_TARGET=WIN95 when OS_ARCH=WINNT

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 702362 [details] [diff] [review]
Don't build NSPR with OS_TARGET=WIN95 when OS_ARCH=WINNT

Whether we decide to switch to OS_TARGET=WINNT for nspr and nss, I think we still want this particular change, because it puts back the power in our hands: we can choose between WIN95 and WINNT with --enable-win32-target, which we can't at the moment, without modifying nspr.

Comment 9

[Mike Hommey [:glandium]]

oh my... the nspr build system has the "lib" prefix hardcoded.

Comment 10

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #9)
> oh my... the nspr build system has the "lib" prefix hardcoded.

http://hg.mozilla.org/mozilla-central/file/77e4b2a4cc31/nsprpub/config/rules.mk#l83

Comment 11

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Perhaps we should just make OS_TARGET=WIN95 a synonym for OS_TARGET=WINNT and only have one configuration in NSPR. I'm pretty sure that only one of the two configurations is being tested in our automated tests (which one?). If we were to consolidate them to one configuration, then we would have to decide whether the use the WINNT implementation or the WIN95 implementation. I guess the WINNT configuration is supposed to be better for performance but on the other hand the WIN95 configuration has been tested for many years in Gecko.

Comment 12

[Wan-Teh Chang]

The OS_TARGET=WIN95 build configuration is preferred. The use of "WIN95"
in this build configuration is historical and has become very misleading
today. I remember someone filed a bug report recently to rename this
build configuration and make it the default. That's what I would recommend.

Comment 13

[Kai Engert [:KaiE:]]

WIN95 is the newer code based on recent explanations from Wan-Teh, WINNT uses older APIs.

We use WIN95. Wan-Teh had suggested to rename WIN95 to something better, he proposed WIN32, but I'm not sure that's the best name.

See also bug 814982 where I propose to change the NSPR default to use WIN95.

See also bug 772226 comment 18 where we ran into problems with the WINNT configuration, and had decided that we don't care.


(In reply to Brian Smith (:bsmith) from comment #11)
> Perhaps we should just make OS_TARGET=WIN95 a synonym for OS_TARGET=WINNT

Please no, that would be even more confusing that what we have today - at least today we are able to distinguish things! :)