Closed
Bug 830787
Opened 11 years ago
Closed 11 years ago
Move jsscope to vm/Shape
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: evilpie, Assigned: evilpie)
Details
Attachments
(2 files, 1 obsolete file)
464 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
42.02 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•11 years ago
|
Summary: Move jsscope to vm/Scope → Move jsscope to vm/Shape
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
This includes some other include fixes when I just couldn't hold back.
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #702368 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Attachment #702365 -
Flags: review?(jorendorff)
Assignee | ||
Updated•11 years ago
|
Attachment #702371 -
Flags: review?(jorendorff)
Comment 4•11 years ago
|
||
Comment on attachment 702365 [details] [diff] [review] move jsscope.* to vm/Shape* Don't push this changeset separately (so as not to screw up future bisecting). Squash the two together using qfold or whatever.
Attachment #702365 -
Flags: review?(jorendorff) → review+
Comment 5•11 years ago
|
||
Comment on attachment 702371 [details] [diff] [review] fix includes/build v2 In frontend/Parser.cpp: > >+ I think we still don't do two blank lines in a row, right? Otherwise, looks great. Thanks for doing this. It's long overdue.
Attachment #702371 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Thanks! I think I am going to move some more stuff in a few other bugs. https://hg.mozilla.org/integration/mozilla-inbound/rev/3b42359a9f6b
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3b42359a9f6b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•