830901 - [App Updates] Disabling all checkboxes in the update prompt, hitting later, and return prompt - checkboxes are enabled, but download button is disabled

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jason Smith [:jsmith]]

Build: B2G 18 1/15/2013
Device: Unagi

Steps:

1. Find an app update on your device
2. Select the update prompt
3. Uncheck each checkbox for each app
4. Hit "Later"
5. Select the update prompt again

Expected:

The checkboxes should be enabled and the download button should be enabled.

Actual:

The checkboxes are enabled, download button is disabled. Easy to work-around, but an annoying inconsistency.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Patches welcome, but this isn't likely to draw much attention over other work in v1.

Comment 3

[Leo]

Wayne, would you apply leo+ to this bug, since the Bug 858354 has been resolved-duplicate.

Comment 4

[Jason Smith [:jsmith]]

(In reply to leo.bugzilla.gaia from comment #3)
> Wayne, would you apply leo+ to this bug, since the Bug 858354 has been
> resolved-duplicate.

I'll nom first per your request.

FWIW, we didn't block nor track this originally, because the workaround here is simple. It's awkward, though.

Comment 5

[Leo]

Hi Jason, 

The fix is real simple, just adding updateDownloadButton() call at the end of showDownloadPrompt function in update_manager.js

I'm making the pull request now, hopefully this patch can be pushed in.

Thanks

Comment 6

[Leo]

Attachment: Pull request url

Comment 7

[Julien Wajsberg [:julienw]]

Please add an unit test for this case.

The update functionality has a quite comprehensive suite and I'd like to keep it this way.

Thanks !

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 737330 [details]
Pull request url

Redirect review

Comment 9

[Dylan Oliver [:doliver]]

leo+ as this is one of the blocking bugs from the QE1 test cycle.

Comment 10

[Leo]

Hi Julien,

I have added a unit test for this. Please review again. Thanks!


(In reply to Julien Wajsberg [:julienw] from comment #7)
> Please add an unit test for this case.
> 
> The update functionality has a quite comprehensive suite and I'd like to
> keep it this way.
> 
> Thanks !

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 737330 [details]
Pull request url

r=me

thanks a lot !

Comment 12

[Julien Wajsberg [:julienw]]

master: 671e2b3a0ac28c77930a795414df48c7d6690359

Comment 13

[James Lal [:lightsofapollo]]

Uplifted 671e2b3a0ac28c77930a795414df48c7d6690359 to:
v1-train: 3774a756e70ec322d363b49d29fea43c5b214cff

Comment 14

[Jason Smith [:jsmith]]

Verified on 4/18 build.